fix: Track variable usage in ghosted type list initializers (fixes #398)#400
Merged
kjonescertinia merged 3 commits intomainfrom Nov 25, 2025
Merged
Conversation
When initializing a List/Set with a ghosted element type (external namespace types without definitions), the variable usage tracking was being skipped. This caused variables used within the list initializer to be incorrectly flagged as unused. The fix ensures that parts.foreach(_.verify(input, context)) is called even when the element type lookup fails, maintaining proper variable usage tracking while skipping type compatibility checks for unavailable types.
pwrightcertinia
previously approved these changes
Nov 24, 2025
…-type-list-unused # Conflicts: # jvm/src/test/scala/com/nawforce/apexlink/plugin/UnusedTest.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ext__Type__c)SetOrListCreatorRest.verify()was returning early without tracking variable usage when the element type lookup failedChanges
parts.foreach(_.verify(input, context))call before early return when element type is ghosted, ensuring variable usage is tracked even when type compatibility checks are skippedTest plan
sbt scalafmtAllFixes #398