Open
Conversation
kjonescertinia
force-pushed
the
remove-forceignore-v1
branch
from
550fe61 to
7f7d506
Compare
Simplifies codebase by removing the legacy v1 ForceIgnore implementation and always using ForceIgnoreV2 (node-ignore compatible). Changes: - Delete ForceIgnore.scala (v1 implementation) and ForceIgnoreVersion.scala - Remove ForceIgnoreInterface trait - use ForceIgnoreV2 directly - Update DocumentIndex, Layer, Workspace to always use V2 - Add deprecation warning when forceIgnoreVersion option is set in sfdx-project.json - Remove related test files for v1 implementation - Update tests to verify deprecation warning behavior Closes #383
kjonescertinia
force-pushed
the
remove-forceignore-v1
branch
from
7f7d506 to
a04328b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
forceIgnoreVersionoption is set in sfdx-project.jsonChanges
Deleted files:
ForceIgnore.scala- v1 implementationForceIgnoreVersion.scala- version enum and switching logicForceIgnoreTests.scala,IgnoreRuleTest.scala,ForceIgnoreVersionTest.scala- v1-related testsModified files:
DocumentIndex.scala- usesForceIgnoreV2directly (removed interface abstraction)ForceIgnoreV2.scala- removedextends ForceIgnoreInterfaceSFDXProject.scala- emits deprecation warning when forceIgnoreVersion option is presentLayer.scala,Workspace.scala- simplified, removed version parametersDocumentIndexTest.scala,ApexConfigTest.scala- updated testsTest plan
Closes #383
🤖 Generated with Claude Code