Reduce frequency of alerts#57
Conversation
| componentLoadThresholdDegraded < criticalComponentLoadThreshold | ||
| ) { | ||
| alert.componentLoadTimeDegraded = componentLoadThresholdDegraded; | ||
| alert.alertType = NORMAL; |
There was a problem hiding this comment.
This should be left alone.
| /***************************************************************************** | ||
| * UI ALERT TYPES | ||
| ******************************************************************************/ | ||
| export const NORMAL = 'normal'; |
There was a problem hiding this comment.
This needs reverting
|
|
||
| // Then | ||
| expect(results).to.have.lengthOf(1); | ||
| expect(results[0].alertType).to.equal(NORMAL); |
There was a problem hiding this comment.
This needs reverting
@moladimejicertinia When we spoke we said "I want them to be less "shouty" so that they are more pleasant to read" was part of the bitbucket changes, NOT part of these changes. In future can we please write down notes so there is no confusion. |
package.json
Outdated
| { | ||
| "name": "@apexdevtools/benchmarker", | ||
| "version": "6.0.2", | ||
| "version": "6.1.2", |
There was a problem hiding this comment.
This should be 6.1.0
CHANGELOG.md
Outdated
| ### Added | ||
|
|
||
| - New property on `TestStepDescription`, `additionalData`. Provide custom string information to link to results. | ||
|
|
There was a problem hiding this comment.
Can we revert this new line please
CHANGELOG.md
Outdated
| ### Added | ||
|
|
||
| - New alerts config for global and per test usage. Used for reporting on degradations over time. | ||
|
|
test/services/uiAlert.test.ts
Outdated
|
|
||
| import { UiTestResultDTO } from '../../src/database/uiTestResult'; | ||
| import { NORMAL, CRITICAL } from '../../src/shared/constants'; | ||
| import { CRITICAL } from '../../src/shared/constants'; |
There was a problem hiding this comment.
This needs NORMAL adding back
5 participants
As a user, when I receive alerts, I want to reduce the frequency of alerts so that I am not overwhelmed by notifications.
As a user, when I see alert messages, I want them to be less "shouty" so that they are more pleasant to read.
The goal is to update the logic for alert notifications. This involves ensuring that if an alert has been sent within the last three days, no new alert will be created. Additionally, the language used in the alerts needs to be toned down.