fix: change getSObjects() return type from List to RecordSet$ for for…#39
Merged
pwrightcertinia merged 1 commit intomainfrom Aug 19, 2025
Merged
Conversation
…-loop compatibility
Change getSObjects() methods to return RecordSet$<SObject> instead of
List<SObject> to support recordset iteration in for-loops like SOQL queries
and Database.query().
This enables the syntax:
for(List<SObject> cursorBlock : parent.getSObjects('relationshipName')) {}
Without this fix, the above produces the error:
"Incompatible types in assignment, from 'System.SObject' to 'System.List<System.SObject>'"
Changes:
- Add import for com.nawforce.runforce.Internal.RecordSet$
- Change getSObjects(SObjectField) return type: List<SObject> → RecordSet$<SObject>
- Change getSObjects(String) return type: List<SObject> → RecordSet$<SObject>
Fixes #38
Related: apex-dev-tools/apex-ls#328
pwrightcertinia
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…-loop compatibility
Change getSObjects() methods to return RecordSet$ instead of List to support recordset iteration in for-loops like SOQL queries and Database.query().
This enables the syntax:
for(List cursorBlock : parent.getSObjects('relationshipName')) {}
Without this fix, the above produces the error:
"Incompatible types in assignment, from 'System.SObject' to 'System.List<System.SObject>'"
Changes:
Fixes #38
Related: apex-dev-tools/apex-ls#328