fix: handle options parsing and exit code correctly#609
Open
DinoChiesa wants to merge 3 commits intoapigee:mainfrom
Open
fix: handle options parsing and exit code correctly#609DinoChiesa wants to merge 3 commits intoapigee:mainfrom
DinoChiesa wants to merge 3 commits intoapigee:mainfrom
Conversation
Collaborator
Author
|
I updated the GH actions to use node v24 for tests. See if that makes sense to you. Node V20 is in maintenance, will exit Maintenance in April 2026. So it's time to move. node v24 is active LTS now. So I thought it would make sense to move to v24. WDYT @ssvaidyanathan ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses issue #608 .
With the change to commander v14.x, handling of the options overrides changed. As a result, the .apigeelintrc file was being read, but not handled correctly. The existing tests missed this change in behavior.
This restores the .apigeelintrc handling to correct behavior.
To be clear: in v2.78.0 , apigeelint was not loading .apigeelintrc files correctly. With this change, it will do so correctly.