Skip to content

Conversation

@varlogen
Copy link
Collaborator

@varlogen varlogen commented May 24, 2019

  • add validations
  • test idlistviewmodel
  • correct errors if they are

close #25

@varlogen varlogen requested a review from levkovalenko May 24, 2019 20:43
@levkovalenko
Copy link
Member

PR for @malinink

}

ids := idsViewModel.CoborrowersIdSlice
for id1 := 0; id1 < len(ids); id1++ {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ка4мар, скажи вложенным циклам нет!

}

// check equal values client id and coborrower's id
vms[0].SetClientId(2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

я бы тут передалал, и задал бы массив с не валидными IdsViewModel & массив с "ошибками"

@varlogen varlogen changed the title Feature 15 test idlistviewmodel May 25, 2019
@varlogen varlogen requested a review from malinink May 25, 2019 21:05
Add .iml and .xml files to gitignore
@TimurSirkin
Copy link
Collaborator

Накосячил, случайно запушил свои коммиты в родительскую ветку, тобишь в эту

Co-Authored-By: Lev Kovalenko <levozavr@mail.ru>
@varlogen varlogen requested a review from malinink May 26, 2019 20:22
@malinink
Copy link
Contributor

@varlogen подмерджите дев, резрезолвите конфликты

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test idlistviewmodel

5 participants