Open
Conversation
…ix bugs. Refactor related test files.
…ve to commit ID. Update documentation and examples accordingly. Add tests for commit hash resolution and validation logic.
📊 Coverage Report
Legend✅ Passing | ❌ Failing Generated by Appcircle CLI Coverage Reporter |
ozeryilm
reviewed
Oct 21, 2025
| type: CommandParameterTypes.PASSWORD, | ||
| valueType: 'string', | ||
| required: true | ||
| required: false |
Contributor
There was a problem hiding this comment.
Bu değişikliği yapmaya gerek var mıydı?
Contributor
Author
There was a problem hiding this comment.
Evet. Çünkü passwordun optional olması isteniyor.
…ure with appropriate exit codes.
📊 Coverage Report
Legend✅ Passing | ❌ Failing Generated by Appcircle CLI Coverage Reporter |
📊 Coverage Report
Legend✅ Passing | ❌ Failing Generated by Appcircle CLI Coverage Reporter |
📊 Coverage Report
Legend✅ Passing | ❌ Failing Generated by Appcircle CLI Coverage Reporter |
📊 Coverage Report
Legend✅ Passing | ❌ Failing Generated by Appcircle CLI Coverage Reporter |
…ed authorization messages. Update command runner to handle errors gracefully with try-catch blocks. Add unit test for 403 error handling logic to ensure detailed messages are returned.
…-catch blocks in multiple command handling functions. This ensures graceful failure and proper spinner management during asynchronous operations.
📊 Coverage Report
Legend✅ Passing | ❌ Failing Generated by Appcircle CLI Coverage Reporter |
ozeryilm
approved these changes
Oct 22, 2025
📊 Coverage Report
Legend✅ Passing | ❌ Failing Generated by Appcircle CLI Coverage Reporter |
#98) * Update Jenkinsfile to allow publishing when building a tag in addition to the existing publish parameter. * 2.7.6-alpha.4 * Refactor error messages in command runner and interactive runner to remove user-specific context, ensuring consistency in error reporting. Update unit tests to reflect changes in error handling. * 2.7.6-alpha.5 * Enhance CLI documentation for `--no-wait` parameter compatibility with monitoring modes and improve path handling by ensuring tilde expansion only occurs at the start of paths. Update related functions to utilize the new path expansion logic and adjust unit tests for error message consistency. * Refactor import statements in command-runner-utilities.ts to use ES6 module syntax for consistency across the codebase. * Enhance unit tests for file path utilities by improving tilde expansion logic and error handling. Update mocks to use `vi.spyOn` for better control and consistency. Adjust assertions to reflect new behavior in path resolution and error messages. * 2.7.6-alpha.6 * Enhance parameter validation in command runner to ensure compatibility between `--no-wait`, `--monitor`, and download options. Update documentation to reflect these changes and clarify error handling for incompatible parameter combinations. Add unit tests to verify correct behavior when conflicting flags are used. * Improve validation for `--monitor` parameter in command runner to handle invalid values and missing arguments. Update unit tests to ensure proper error handling for these scenarios. * Update documentation for `--monitor` parameter to clarify valid values and error handling. Modify E2E tests to check for specific error messages related to invalid Personal Access Key format and monitor mode. Adjust unit tests to reflect optional parameter syntax for better validation. * 2.7.6-alpha.7 * Update E2E tests to require at least 1 successful operation for concurrent commands, reflecting expected behavior under config file access conflicts or timing issues. * 2.7.6 * #BE-7645 Fix Release Note Update for Uploading AAB File (#99) * Fix release not update for uploading aab (testing-distribution). * Add unit tests for appPath validation in file upload utilities. * 2.7.7-alpha.1 * Enhance error handling in upload functions to provide clearer messages for file size, API response format, and file extension errors. Improve spinner management during error reporting for better user experience. * 2.7.7-alpha.2 * Update documentation and interactive input handling for release notes. Clarify that two blank lines are required to finish entering release notes instead of pressing Enter twice. * 2.7.7 * Refactor version ID retrieval and release candidate marking in command runner. * Add unit tests for handleReleaseCandidateMarking to validate appVersionId and versionId retrieval from commitFileResponse, and ensure proper error handling when no app versions are found. * 2.7.8-alpha.1 * Add getAppVersionAfterUploadWithTaskCompletion function to improve app version retrieval after uploads, including task completion handling and filtering by upload time. Enhance unit tests to validate new functionality and ensure accurate version selection based on file size and name. * 2.7.8-alpha.2 * Enhance upload functions to support custom tags and release notes. * Remove deprecated release notes update logic from handleDistributionUpload and clean up related tests. Update unit tests to reflect changes in upload functionality. * 2.7.8-alpha.3 * Refactor Jenkins PAT (#100) * Fix release not update for uploading aab (testing-distribution). * Add unit tests for appPath validation in file upload utilities. * 2.7.7-alpha.1 * Enhance error handling in upload functions to provide clearer messages for file size, API response format, and file extension errors. Improve spinner management during error reporting for better user experience. * 2.7.7-alpha.2 * Update documentation and interactive input handling for release notes. Clarify that two blank lines are required to finish entering release notes instead of pressing Enter twice. * 2.7.7 * Refactor version ID retrieval and release candidate marking in command runner. * Add unit tests for handleReleaseCandidateMarking to validate appVersionId and versionId retrieval from commitFileResponse, and ensure proper error handling when no app versions are found. * 2.7.8-alpha.1 * Add getAppVersionAfterUploadWithTaskCompletion function to improve app version retrieval after uploads, including task completion handling and filtering by upload time. Enhance unit tests to validate new functionality and ensure accurate version selection based on file size and name. * 2.7.8-alpha.2 * Enhance upload functions to support custom tags and release notes. * Remove deprecated release notes update logic from handleDistributionUpload and clean up related tests. Update unit tests to reflect changes in upload functionality. * 2.7.8-alpha.3 * Update GitHub PAT credential in Jenkinsfile.
📊 Coverage Report
Legend✅ Passing | ❌ Failing Generated by Appcircle CLI Coverage Reporter |
📊 Coverage Report
Legend✅ Passing | ❌ Failing Generated by Appcircle CLI Coverage Reporter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.