[Suggestion] Currency from locale not working as expected#76
Open
marlonfrr wants to merge 1 commit intoappditto:masterfrom
Open
[Suggestion] Currency from locale not working as expected#76marlonfrr wants to merge 1 commit intoappditto:masterfrom
marlonfrr wants to merge 1 commit intoappditto:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
In the code snippet shown below, there is no way to get the currency based on local given that when the locale is supported
locale.countrycodeis not null, so it will not check for the currency. And in a country that is doesn’t have currency support,locale.countrycodewill be null, and when trying to check ifcurrency.getLocale().countryCode.toUpperCase() == locale.countryCode.toUpperCase()toUpperCase()will throw becauselocale.countryCodeis null. So the work around for this is to change the condition to be:if (locale != null && locale.countryCode != null).As described above, when using an unsupported country
toUpperCase()was called on null:This was found in the lib/model/available_currency.dart file.