Skip to content

xw - increase wait_until time when loading a page #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weixing2014 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

xw - increase wait_until time when loading a page #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7c2299
xw - increase wait_until time when loading a page
weixing2014 Nov 2, 2016
7712e10
xw - fix broken tests
weixing2014 Nov 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ae_page_objects/document_loader.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ def initialize(query, strategy)

def load
begin
AePageObjects.wait_until do
AePageObjects.wait_until(10) do
@query.conditions.each do |document_condition|
if document = @strategy.load_document_with_condition(document_condition)
return document
Expand Down
10 changes: 4 additions & 6 deletions test/unit/document_loader_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,11 @@ def test_load_page__document_not_loaded_error
loader = DocumentLoader.new(query, strategy)

sequence = sequence('sequence')
strategy.expects(:load_document_with_condition).in_sequence(sequence).with(query.conditions[0]).returns(nil)
strategy.expects(:load_document_with_condition).in_sequence(sequence).with(query.conditions[1]).returns(nil)
strategy.expects(:load_document_with_condition).in_sequence(sequence).with(query.conditions[2]).returns(nil)
strategy.stubs(:load_document_with_condition).in_sequence(sequence).with(query.conditions[0]).returns(nil)
strategy.stubs(:load_document_with_condition).in_sequence(sequence).with(query.conditions[1]).returns(nil)
strategy.stubs(:load_document_with_condition).in_sequence(sequence).with(query.conditions[2]).returns(nil)

strategy.expects(:document_not_loaded_error_message).with(query).returns("hello")
strategy.stubs(:document_not_loaded_error_message).with(query).returns("hello")

raised = assert_raise DocumentLoadError do
loader.load
Expand Down Expand Up @@ -113,5 +113,3 @@ def default_max_wait_time
end
end
end