feat: add option to set asyncmap/asyncfilter concurrency pool limit by eglitise · Pull Request #58 · appium/asyncbox

eglitise · 2026-01-26T08:43:04Z

This should allow us to replace Bluebird's B.map throughout the org.
Worth noting that B.filter does not have a concurrency option at all.

Copilot

Pull request overview

This pull request adds a concurrency pool limit option to the asyncmap and asyncfilter functions, allowing users to control the level of parallelism when processing collections. This feature aims to replace Bluebird's B.map functionality throughout the organization.

Changes:

Added MapFilterOptions type that accepts boolean or {concurrency: number} to control execution mode
Implemented worker pool pattern for both asyncmap and asyncfilter with configurable concurrency
Updated tests to verify concurrent execution behavior and validation of invalid concurrency values
Updated documentation with examples of sequential, parallel, and limited concurrency execution

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File	Description
lib/types.ts	Added `MapFilterOptions` type definition to support boolean or concurrency object options
lib/asyncbox.ts	Refactored `asyncmap` and `asyncfilter` to support concurrency pool limits using worker pattern
test/asyncbox-specs.ts	Added tests for concurrency mode, adjusted timing expectations, and added validation tests
README.md	Updated documentation with concurrency examples and corrected function signatures

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/asyncbox-specs.ts

lib/asyncbox.ts

README.md

lib/asyncbox.ts

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/asyncbox-specs.ts

lib/asyncbox.ts

KazuCocoa

lgtm

mykola-mokhnach · 2026-01-27T19:20:19Z

lib/asyncbox.ts

  coll: T[],
-  mapper: (value: T) => R | Promise<R>,
-  runInParallel = true,
+  mapper: (value: T) => PromiseLike<R>,


is this a breaking change? I assume the previous implementation did not force the mapper to be a promise

I changed the signature only because p-limit required a PromiseLike input. Ultimately the function is intended to be used only for promises, but I'll see if I can somehow adjust it to keep the signature.

Added async wrappers for both mapper and filter, which allows to keep the previous signature. I've also added new tests to confirm this.

mykola-mokhnach · 2026-01-27T19:21:35Z

package.json

    "singleQuote": true
  },
+  "dependencies": {
+    "p-limit": "^7.2.0"


I assume the main reason for the major version bump was to get rid of any third party dependencies, however now we still add one.

Would you mind if I try to actually implement concurrent mapping and filtering as part of this module without using third party modules?

I don't consider the removal of dependencies on its own to require a major version bump. I was merely investigating how to achieve that, and decided to modernize the package along the way, which resulted in the major bumps.
Regarding p-limit specifically, while I still maintain my stance that it's preferable to minimize third party dependencies here, there's 3 main reasons why I added it:

Replacing it with native functionality requires somewhat non-trivial code (unlike the previous uses of bluebird and lodash). This is also why I have not attempted to remove lodash from teen_process, since it uses _.isBuffer, whose replacement would require more than a one-liner.

It is a very small module (12KB unpacked, compared to 632KB for bluebird and 1.41MB for lodash), and is purpose-built for this use case.

It comes from a trusted developer, which gives confidence in the module's coverage of any edge cases.

Hand-rolling the concurrency is certainly still possible, but given the above, I'm not sure if it's worth the effort, even with AI assistance.

## [6.1.0](v6.0.1...v6.1.0) (2026-01-28) ### Features * add option to set asyncmap/asyncfilter concurrency pool limit ([#58](#58)) ([b1e6535](b1e6535)) ### Miscellaneous Chores * **deps-dev:** bump @appium/eslint-config-appium-ts ([#59](#59)) ([e38530e](e38530e))

github-actions · 2026-01-28T06:59:22Z

🎉 This PR is included in version 6.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

feat: add option to set asyncmap/asyncfilter concurrency pool limit

884d812

eglitise requested review from KazuCocoa, Copilot and mykola-mokhnach January 26, 2026 08:43

Copilot started reviewing on behalf of eglitise January 26, 2026 08:43 View session

Copilot AI reviewed Jan 26, 2026

View reviewed changes

address copilot comments

7a5c304

eglitise requested a review from Copilot January 26, 2026 09:05

Copilot started reviewing on behalf of eglitise January 26, 2026 09:05 View session

mykola-mokhnach reviewed Jan 26, 2026

View reviewed changes

lib/asyncbox.ts Show resolved Hide resolved

Copilot AI reviewed Jan 26, 2026

View reviewed changes

test/asyncbox-specs.ts Outdated Show resolved Hide resolved

eglitise added 2 commits January 26, 2026 11:08

try to reduce test flakiness

6050a00

update mocha syntax

1417aa2

mykola-mokhnach reviewed Jan 26, 2026

View reviewed changes

lib/asyncbox.ts Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Jan 26, 2026

View reviewed changes

lib/asyncbox.ts Outdated Show resolved Hide resolved

eglitise added 2 commits January 26, 2026 12:54

use p-limit to avoid reinventing the wheel

3a06cf8

simplify with limitFunction

01fa1a2

eglitise requested a review from mykola-mokhnach January 26, 2026 11:20

mykola-mokhnach reviewed Jan 26, 2026

View reviewed changes

lib/asyncbox.ts Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Jan 26, 2026

View reviewed changes

lib/asyncbox.ts Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Jan 26, 2026

View reviewed changes

lib/asyncbox.ts Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Jan 26, 2026

View reviewed changes

lib/asyncbox.ts Outdated Show resolved Hide resolved

address review comments

84e745a

mykola-mokhnach reviewed Jan 26, 2026

View reviewed changes

lib/asyncbox.ts Outdated Show resolved Hide resolved

address review comments

aae3b10

KazuCocoa approved these changes Jan 27, 2026

View reviewed changes

eglitise requested a review from mykola-mokhnach January 27, 2026 10:34

mykola-mokhnach reviewed Jan 27, 2026

View reviewed changes

mykola-mokhnach approved these changes Jan 27, 2026

View reviewed changes

ensure it still works with sync inputs

1abd3f8

eglitise merged commit b1e6535 into appium:master Jan 28, 2026
6 checks passed

eglitise deleted the concurrencies branch January 28, 2026 06:57

github-actions bot added the released label Jan 28, 2026

Uh oh!

Conversation

eglitise commented Jan 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KazuCocoa left a comment

Choose a reason for hiding this comment

Uh oh!

mykola-mokhnach Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

eglitise Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

eglitise Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

mykola-mokhnach Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

eglitise Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants