-
Notifications
You must be signed in to change notification settings - Fork 557
feat: color and plain modes for --progress flag #899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
345bf01 to
c59d4d2
Compare
|
I don't see anything out of the ordinary on these changes, but I also don't have permissions to approve PRs. You will have to wait for a maintainer to come back to this for a ✅ . |
c59d4d2 to
9e1b44b
Compare
|
@katiewasnothere @saehejkang what do you guys think about making color mode the default mode instead of ansi since it visually looks a lot more appealing? |
|
@PhantomInTheWire From an accessibility standpoint, I think we should keep the default something without colors. |
|
sure i guess that makes sense, can you take a look again i have refactored with the requested change @katiewasnothere |
#915 is open for using the standard buildkit environment variables to set color choices there. Consider filing a follow-on issue for allowing users to set a persistent default for non-build So far our system properties are all backed by user defaults but we've discussed internally changing this to environment variables. That would allow users to set their global defaults in an rc file or profile, and then override them on a per-terminal basis. |
c9c247a to
3fc3c73
Compare
|
@katiewasnothere quick ping in case this got buried |
17760f7 to
be0f551
Compare
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
be0f551 to
fc6570b
Compare
Type of Change
Motivation and Context
relevant issue: #641
Adds two new modes to
--progress: plain and color.plain: Produces simple, line-by-line text output with no ANSI escape codes. Ideal for writing to log files or environments that don’t support terminal control sequences.
color: Similar to the existing ANSI mode but with enhanced color usage. This mode provides a more expressive visual display. If it sounds good, we could consider making it the default in this or a follow up pr.
Testing