Skip to content

Conversation

@czechboy0
Copy link
Contributor

Motivation:

As part of expanding platform and CI coverage of Swift Configuration, Swift Metrics should also build on Wasm.

Modifications:

  • Brought over locking changes from Swift Log to support Wasm.
  • Hid some APIs that require Dispatch when Dispatch isn't available.

Result:

The package now builds against the Wasm SDK, both normal and the test targets.

@czechboy0 czechboy0 requested a review from FranzBusch October 13, 2025 10:14
@czechboy0 czechboy0 added the semver/none No version bump required. label Oct 13, 2025
@scottmarchant
Copy link

@czechboy0 I pulled down your branch and it compiles fine to wasm. It looks like it just needs rebased or merged with the latest main. I resolved the conflicts locally, they weren't very hard. Just a few #if's in the test files conflicted with lines of change to transition to Swift Testing.

Any chance you might be able to resolve the conflicts. Or would you be ok if I resolved them for you and rebased your branch on the latest main?

Copy link

@scottmarchant scottmarchant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I pulled the changes down locally and was able to compile to wasm.

@scottmarchant
Copy link

@czechboy0 Just wanted to check one last time before I try to push to your branch with a rebase to update on the latest main. Is updating with the latest main something you're able to do, or are you ok with me updating it?

Please let me know how I can help 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver/none No version bump required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants