fix: handle empty collection in binarySearch to prevent crash#62
Open
Nepomuk5665 wants to merge 1 commit intoapple:mainfrom
Open
fix: handle empty collection in binarySearch to prevent crash#62Nepomuk5665 wants to merge 1 commit intoapple:mainfrom
Nepomuk5665 wants to merge 1 commit intoapple:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a runtime crash in
LLBCASFileTree.binarySearchwhen called with an empty collection.The Bug
The current implementation immediately calls
elements.index(before: elements.endIndex)on line 16 without checking if the collection is empty. For an empty collection,startIndex == endIndex, and callingindex(before: endIndex)is undefined behavior that causes a crash.The Fix
Added an early guard clause to return
nilfor empty collections before attempting to compute indices:This is the correct semantic behavior - searching for an element in an empty collection should return
nil(not found), not crash.Impact