Fix apppack.toml artifact archival for custom APPPACK_TOML paths #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When APPPACK_TOML env var is set to a custom location, the build process now copies the file to the default location (apppack.toml) after the build completes. This ensures the configuration is properly included in build artifacts regardless of its source location. Changes: - Add CopyAppPackTomlToDefault() function to handle the copy operation - Call the function after build completion with non-fatal error handling - Add comprehensive test coverage for the new functionality - Use DefaultAppPackTomlFilename constant for consistency 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Context
This is a follow-up to PR #11 which added support for reading apppack.toml from a custom location via the APPPACK_TOML environment variable. However, the build artifacts were missing the configuration file when it was read from a non-default location.
Changes
CopyAppPackTomlToDefault()function to copy custom config to default locationDefaultAppPackTomlFilenameconstant for consistencyTest plan
CopyAppPackTomlToDefault()covering all scenarios🤖 Generated with Claude Code