-
Notifications
You must be signed in to change notification settings - Fork 149
feat: Flutter SDK update for version 20.3.3 #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -111,7 +111,7 @@ class Storage extends Service { | |||||||||||||||||||
| .replaceAll('{fileId}', fileId); | ||||||||||||||||||||
|
|
||||||||||||||||||||
| final Map<String, dynamic> apiParams = { | ||||||||||||||||||||
| 'name': name, | ||||||||||||||||||||
| if (name != null) 'name': name, | ||||||||||||||||||||
| 'permissions': permissions, | ||||||||||||||||||||
| }; | ||||||||||||||||||||
|
Comment on lines
113
to
116
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: cat -n lib/services/storage.dart | head -130 | tail -30Repository: appwrite/sdk-for-flutter Length of output: 1287 🏁 Script executed: # Check the function signature to see parameter types
rg -n "permissions" lib/services/storage.dart -B5 -A2Repository: appwrite/sdk-for-flutter Length of output: 1694 🏁 Script executed: # Check how apiParams is used after being defined
rg -n "apiParams" lib/services/storage.dart -A10Repository: appwrite/sdk-for-flutter Length of output: 3629 Inconsistent null handling for The Apply the same conditional pattern: 🔧 Suggested fix final Map<String, dynamic> apiParams = {
if (name != null) 'name': name,
- 'permissions': permissions,
+ if (permissions != null) 'permissions': permissions,
};📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||
|
|
||||||||||||||||||||
|
|
||||||||||||||||||||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: appwrite/sdk-for-flutter
Length of output: 1130
🏁 Script executed:
Repository: appwrite/sdk-for-flutter
Length of output: 1492
🏁 Script executed:
Repository: appwrite/sdk-for-flutter
Length of output: 181
🏁 Script executed:
Repository: appwrite/sdk-for-flutter
Length of output: 135
🏁 Script executed:
Repository: appwrite/sdk-for-flutter
Length of output: 50
🏁 Script executed:
Repository: appwrite/sdk-for-flutter
Length of output: 15603
Add parameter documentation for
durationto the docstring.The implementation is correct and follows the established pattern for optional parameters. However, the docstring (lines 115-119) completely omits the new
durationparameter. Update the docstring to document what this parameter does and its valid range or constraints. The example indocs/examples/account/create-jwt.mdshows it accepts values like 0, which could serve as a reference.🤖 Prompt for AI Agents