Skip to content

Conversation

@jpopesculian
Copy link
Contributor

@jpopesculian jpopesculian commented Jan 14, 2026

Summary by CodeRabbit

  • Chores
    • Updated Docker build configuration to support parameterizable base image reference
    • Enhanced Docker image build process with improved dependency management and environment setup

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 14, 2026

📝 Walkthrough

Walkthrough

The pull request parameterizes the Kubimo Dockerfile to accept a base image reference as a build argument (KUBIMO_MARIMO_IMAGE) with a default value. This build argument is exposed through the Docker Bake configuration file, allowing the base image to be customized at build time.

Changes

Cohort / File(s) Summary
Docker Bake Configuration
docker-bake.dev.hcl
Adds args block to docker-metadata-kubimo target with new build argument KUBIMO_MARIMO_IMAGE set to ghcr.io/aqora-io/kubimo-marimo:${TAG}, enabling dynamic base image specification.
Kubimo Dockerfile
docker/Dockerfile.kubimo
Parameterizes base image via ARG KUBIMO_MARIMO_IMAGE with default ghcr.io/aqora-io/kubimo-marimo:0.1.9; updates both build and final stages to use FROM ${KUBIMO_MARIMO_IMAGE}. Expands build context to include full Rust compilation (sets workspace, copies rust-toolchain, builds release binary) and adds environment PATH updates and workspace file copies to final stage.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • chore: update marimo version #172: Modifies the base image reference in docker/Dockerfile.kubimo; this PR parameterizes that image through build arguments instead of using a fixed tag.

Poem

🐰 A parameter hops into the Dockerfile so neat,
The base image now dances to a variable beat!
With Rust compiling, and venv in the brew,
Kubimo's container is fresh and made new! 🐇✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: add arg for base docker image' directly and accurately describes the main changes: introducing a KUBIMO_MARIMO_IMAGE build argument to parameterize the base docker image in the Dockerfile.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.



📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f926346 and 84b437f.

📒 Files selected for processing (2)
  • docker-bake.dev.hcl
  • docker/Dockerfile.kubimo
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
  • GitHub Check: Test WASM (chrome)
  • GitHub Check: Test WASM (firefox)
  • GitHub Check: Test WASM (safari)
  • GitHub Check: Test Workspace
  • GitHub Check: linux (aarch64)
  • GitHub Check: macos (x86_64)
  • GitHub Check: macos (aarch64)
  • GitHub Check: windows (x86)
  • GitHub Check: linux (x86_64)
  • GitHub Check: windows (x64)
  • GitHub Check: Build and publish npm package
  • GitHub Check: linux (x86)
🔇 Additional comments (3)
docker/Dockerfile.kubimo (2)

1-3: LGTM! Correct pattern for parameterizing base images in multi-stage builds.

The ARG declaration before the first FROM correctly makes it available for all FROM instructions. The default value provides a stable fallback for standalone builds.


22-22: Consistent use of the parameterized base image.

Both build and final stages now use the same configurable base image, ensuring version consistency across stages.

docker-bake.dev.hcl (1)

7-9: LGTM! Build argument correctly wired to coordinate versions.

The args block properly overrides the Dockerfile default, using ${TAG} to keep the base image version aligned with the output image tag during bake-driven builds.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jpopesculian jpopesculian merged commit 0d40231 into main Jan 14, 2026
27 of 28 checks passed
@jpopesculian jpopesculian deleted the fix-base-docker-tag-arg branch January 14, 2026 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants