Part 1 of qwen 2 compatibility: elif model_type qwen2#45
Open
SolshineCode wants to merge 1 commit intoarcee-ai:mainfrom
Open
Part 1 of qwen 2 compatibility: elif model_type qwen2#45SolshineCode wants to merge 1 commit intoarcee-ai:mainfrom
SolshineCode wants to merge 1 commit intoarcee-ai:mainfrom
Conversation
Line 27 added option for qwen2 architecture to be recognized:
elif data['model_type'] == "qwen2":
data['model_type'] = "mergedqwen2"
data['architectures'][0] = 'MergedQwen2ForCausalLM '
This as part 1 of qwen 2 compatibility.
shamanez
suggested changes
Oct 21, 2024
Contributor
shamanez
left a comment
shamanez
left a comment
There was a problem hiding this comment.
You also need to add the modified modeling.py file to make this work.
Ex: checkout the changes we did for the Llama3 - https://github.com/arcee-ai/DAM/blob/main/dam/modeling/llama3/modeling.py
Author
|
Yes, I anticipate doing that as Part 2. Should I include that into this same PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line 27 added option for qwen2 architecture to be recognized:
elif data['model_type'] == "qwen2":
data['model_type'] = "mergedqwen2"
data['architectures'][0] = 'MergedQwen2ForCausalLM '
This as part 1 of qwen 2 compatibility.