Skip to content

Conversation

@stijnmoreels
Copy link
Member

@stijnmoreels stijnmoreels commented Apr 15, 2025

Add Microsoft ILogger support for the TUnit test framework in the same fashion as the other logging libraries:

  • ILogger support.
  • ILoggerBuilder support.

Closes #371

@stijnmoreels stijnmoreels added the area:logging All issues related to test logging. label Apr 15, 2025
@stijnmoreels stijnmoreels added this to the v2.0 milestone Apr 15, 2025
@netlify
Copy link

netlify bot commented Apr 15, 2025

Deploy Preview for arcus-testing ready!

Name Link
🔨 Latest commit f7f9593
🔍 Latest deploy log https://app.netlify.com/projects/arcus-testing/deploys/6954ce6d3d18cb000855fb3e
😎 Deploy Preview https://deploy-preview-369--arcus-testing.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@arcus-automation
Copy link
Collaborator

arcus-automation commented Apr 15, 2025

🧪 Code coverage summary

Metric Value
Line coverage 🟢 93.1%
Branch coverage 🟢 83.4%

Great job! 😎 Your code coverage is higher than my caffeine levels! ☕

@stijnmoreels stijnmoreels added the feature All issues related to new features label Apr 18, 2025
@stijnmoreels stijnmoreels modified the milestones: v2.0, v2.1 Apr 25, 2025
@stijnmoreels stijnmoreels modified the milestones: v2.1, v2.2 Jun 13, 2025
@stijnmoreels stijnmoreels changed the title feat(logging): add logging support for TUnit test framework feat(logging): add logging support for TUnit test framework (⌛ waiting on TUnit v1) Jun 19, 2025
@stijnmoreels stijnmoreels modified the milestones: v2.2, v2.3 Nov 13, 2025
@stijnmoreels stijnmoreels changed the title feat(logging): add logging support for TUnit test framework (⌛ waiting on TUnit v1) feat(logging): add logging support for TUnit test framework Dec 4, 2025
@stijnmoreels stijnmoreels marked this pull request as ready for review December 31, 2025 07:34
@stijnmoreels stijnmoreels requested a review from a team as a code owner December 31, 2025 07:34
```
</TabItem>
<TabItem value="tunit" label="TUnit">
The `Arcus.Testing.Logging.TUnit` library provides a `TUnitTestLogger` type that's an implementation of the abstracted Microsoft [`ILogger`](https://docs.microsoft.com/en-us/dotnet/api/microsoft.extensions.logging) inside the [TUnit](https://tunit.dev/) test framework.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What benefits does TUnit bring over other testing frameworks ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, it tries a bit too hard to be as flexible as Expecto, I believe. But the extensibility is more rooted in their test infrastructure, which is great. A more minimal approach might benefit it, though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just wondering if we aren't making it ourselves too difficult / give ourselves too much work by supporting all various sorts of testing frameworks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the initial thought process was to support the same testing frameworks that Microsoft has in their documentation, and TUnit was the new kid on the block on that. It's true that we should limit ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:logging All issues related to test logging. feature All issues related to new features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ [New]: add Microsoft ILogger support for TUnit test framework

3 participants