-
Notifications
You must be signed in to change notification settings - Fork 6
feat(logging): add logging support for TUnit test framework #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(logging): add logging support for TUnit test framework #369
Conversation
✅ Deploy Preview for arcus-testing ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🧪 Code coverage summary
Great job! 😎 Your code coverage is higher than my caffeine levels! ☕ |
…tijnmoreels/arcus.testing into feature/add-tunit-test-logging
| ``` | ||
| </TabItem> | ||
| <TabItem value="tunit" label="TUnit"> | ||
| The `Arcus.Testing.Logging.TUnit` library provides a `TUnitTestLogger` type that's an implementation of the abstracted Microsoft [`ILogger`](https://docs.microsoft.com/en-us/dotnet/api/microsoft.extensions.logging) inside the [TUnit](https://tunit.dev/) test framework. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What benefits does TUnit bring over other testing frameworks ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, it tries a bit too hard to be as flexible as Expecto, I believe. But the extensibility is more rooted in their test infrastructure, which is great. A more minimal approach might benefit it, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just wondering if we aren't making it ourselves too difficult / give ourselves too much work by supporting all various sorts of testing frameworks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the initial thought process was to support the same testing frameworks that Microsoft has in their documentation, and TUnit was the new kid on the block on that. It's true that we should limit ourselves.
Add Microsoft
ILoggersupport for the TUnit test framework in the same fashion as the other logging libraries:ILoggersupport.ILoggerBuildersupport.Closes #371