Skip to content

Windows error 1224 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidgohel merged 3 commits into from
Apr 7, 2025
Merged

Windows error 1224 #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7db5461
fix: Windows error 1224
eli-daniels Apr 7, 2025
7c2b5d1
up version
eli-daniels Apr 7, 2025
4441bcd
Add windows to R CMD check action
eli-daniels Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/R-CMD-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
config:
- {os: macOS-latest, r: 'release'}
- {os: ubuntu-20.04, r: 'release'}
- {os: windows-latest, r: 'release'}

env:
R_REMOTES_NO_ERRORS_FROM_WARNINGS: true
Expand Down
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: workspace
Title: Workspace and Data Management Tools
Version: 0.1.1
Version: 0.1.1.0001
Authors@R: c(
person("David", "Gohel", , "david.gohel@ardata.fr", role = c("aut", "cre")),
person("ArData", role = "cph")
Expand Down
2 changes: 1 addition & 1 deletion R/readers.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ read_dataset_in_workspace <- function(x, name) {
cli_abort("Value of {.code name} is not unique in workspace.")
}
file <- file.path(x$dir, objs$file)
read_parquet(file)
read_parquet(file, mmap = FALSE)
}

#' @export
Expand Down
4 changes: 2 additions & 2 deletions R/workspace.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ read_objects_description <- function(x) {
x$dir,
paste0(.datasets_description, ".parquet")
)
read_parquet(file_objects_description)
read_parquet(file_objects_description, mmap = FALSE)
}

create_datasets_folder <- function(x) {
Expand Down Expand Up @@ -200,7 +200,7 @@ unpack_workspace <- function(file) {
dir,
paste0(.datasets_description, ".parquet")
)
objects_desc <- read_parquet(file_datasets_description)
objects_desc <- read_parquet(file_datasets_description, mmap = FALSE)
unlink(file_datasets_description, force = TRUE)
x <- as_workspace_structure(
dir = dir,
Expand Down
Loading