Skip to content

feat: updates installs libraries dependencies by default #2830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
giacomocusinato wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: updates installs libraries dependencies by default #2830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion arduino-ide-extension/src/browser/contributions/first-startup-installer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ export class FirstStartupInstaller extends Contribution {
try {
await this.libraryService.install({
item: builtInLibrary,
installDependencies: true,
noOverwrite: true, // We don't want to automatically replace custom libraries the user might already have in place
installLocation: LibraryLocation.BUILTIN,
});
Expand Down
32 changes: 15 additions & 17 deletions arduino-ide-extension/src/browser/library/library-list-widget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,23 +167,21 @@ export class LibraryListWidget extends ListWidget<
installDependencies = false;
}

if (typeof installDependencies === 'boolean') {
await this.service.install({
item,
version,
progressId,
installDependencies,
});
this.messageService.info(
nls.localize(
'arduino/library/installedSuccessfully',
'Successfully installed library {0}:{1}',
item.name,
version
),
{ timeout: 3000 }
);
}
await this.service.install({
item,
version,
progressId,
noDeps: !installDependencies,
});
this.messageService.info(
nls.localize(
'arduino/library/installedSuccessfully',
'Successfully installed library {0}:{1}',
item.name,
version
),
{ timeout: 3000 }
);
}

protected override async uninstall({
Expand Down
2 changes: 1 addition & 1 deletion arduino-ide-extension/src/common/protocol/library-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export interface LibraryService
item: LibraryPackage;
progressId?: string;
version?: Installable.Version;
installDependencies?: boolean;
noDeps?: boolean;
noOverwrite?: boolean;
installLocation?: LibraryLocation.BUILTIN | LibraryLocation.USER;
}): Promise<void>;
Expand Down
4 changes: 2 additions & 2 deletions arduino-ide-extension/src/node/library-service-impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ export class LibraryServiceImpl
item: LibraryPackage;
progressId?: string;
version?: Installable.Version;
installDependencies?: boolean;
noDeps?: boolean;
noOverwrite?: boolean;
installLocation?: LibraryLocation.BUILTIN | LibraryLocation.USER;
}): Promise<void> {
Expand All @@ -321,7 +321,7 @@ export class LibraryServiceImpl
req.setInstance(instance);
req.setName(item.name);
req.setVersion(version);
req.setNoDeps(!options.installDependencies);
req.setNoDeps(Boolean(options.noDeps));
req.setNoOverwrite(Boolean(options.noOverwrite));
if (options.installLocation === LibraryLocation.BUILTIN) {
req.setInstallLocation(
Expand Down
Loading