fix bug where responses are truncated under certain circumstances #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a SGList has multiple write buffers, SGList#readInto
should iterate through all write buffers and
read the remaining bytes into the destination buffer
until len bytes have been read, or no more bytes remain.
Before this fix, SGList#readInto stopped iterating through the
write buffers at the first write buffer that had no remaining bytes.
However, it can happen that an empty write buffer is between
two write buffers with remaining bytes:
WPTR_BUF -> buffer_x (remaining: 10)
buffer_x+1 (remaining: 0)
buffer_x+2 (remaining: 10)
In that case, the bytes in buffer_x+2 are not read
and the applet returns a truncated response (e.g. when generating a keypair)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to close #72 and open this PR instead because the old PR was tracking our master branch.
Please see the comments in #72 for details about this PR.