Fix missing full stops in error messages #16404
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
cuiweixie
force-pushed
the
typo
branch
3 times, most recently
from
252c719 to
0c34478
Compare
This commit adds missing full stops (periods) to error and warning messages in the Solidity compiler to improve consistency and readability. Changes include: - Added full stop to error message in ContractLevelChecker.cpp for library state variable validation - Added full stops to error messages in NameAndTypeResolver.cpp for base contract definition and inheritance linearization errors - Added full stop to warning message in TypeChecker.cpp for interface function virtual keyword - Added full stop to error message in DocStringParser.cpp for missing parameter name in docstring - Updated corresponding test expectations to match the new error message format All affected error codes: - 9957: Library cannot have non-constant state variables - 2449: Definition of base has to precede definition of derived contract - 5005: Linearization of inheritance graph impossible - 5815: Interface functions are implicitly "virtual" - 3335: No param name given
Collaborator
|
Hello, and thank you for your contribution! Unfortunately, we do not accept PRs with trivial tweaks of this kind. You can report them in #16095 and we'll instead fix them in bulk at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds missing full stops (periods) to error and warning messages in the Solidity compiler to improve consistency and readability.
Changes include:
All affected error codes: