add postprocessing script to select only 50% of best examples and 50% of random examples #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honghanhh
requested changes
Oct 6, 2025
Contributor
honghanhh
left a comment
honghanhh
left a comment
There was a problem hiding this comment.
The logic LGTM 🚀 Just a few comments to remove redundancies & optimize it.
|
|
||
| def create_output_filename() -> str: | ||
| """Create output filename with git SHA and date.""" | ||
| git_sha = get_git_sha() |
Contributor
There was a problem hiding this comment.
Both create_output_filename and create_metadata called get_git_sha() at the beginning, it's better to call once in main() directly before calling these 2 function to avoid redundant calls.
Comment on lines
+69
to
+90
| # Split 1: Best propositions | ||
| for item in data: | ||
| if len(best_split) >= best_limit: | ||
| break | ||
| pair_id = get_pair_id(item) | ||
| is_best = item.get("data", {}).get("best_conflict", False) | ||
|
|
||
| if is_best and pair_id not in used_pair_ids: | ||
| best_split.append(item) | ||
| used_pair_ids.add(pair_id) | ||
|
|
||
| # Split 2: Low-scored propositions | ||
| for item in data: | ||
| if len(low_score_split) >= low_score_limit: | ||
| break | ||
| pair_id = get_pair_id(item) | ||
| avg_score = calculate_average_score(item) | ||
|
|
||
| if avg_score < 4.0 and pair_id not in used_pair_ids: | ||
| low_score_split.append(item) | ||
| used_pair_ids.add(pair_id) | ||
|
|
Contributor
There was a problem hiding this comment.
The function iterates through the entire dataset twice. I think it is possible to be done in a single pass.
| pair_id = get_pair_id(item) | ||
| avg_score = calculate_average_score(item) | ||
|
|
||
| if avg_score < 4.0 and pair_id not in used_pair_ids: |
Contributor
There was a problem hiding this comment.
This value will be used both in moderator agents & post-processing steps, maybe it is worth to save in a constants.py/utils.py for later consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.