Add "CGO_ENABLED=0" to build and release workflow#149
Open
notxarb wants to merge 1 commit intoarminc:masterfrom
Open
Add "CGO_ENABLED=0" to build and release workflow#149notxarb wants to merge 1 commit intoarminc:masterfrom
notxarb wants to merge 1 commit intoarminc:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a bug when trying to use the current release on alpine linux on x86-64.
While debugging an issue with using the release on alpine linux I ran the ldd command:
I did not see the issue with the arm64 version. Probably because it is cross compiled, and will does static linking instead
ldd output from the arm64 file:
Adding the
CGO_ENABLED=0to the build command should force it to do a static build and fix it for alpine linux users.The Makefile passes the
CGO_ENABLED=0when building.Downloading from the build from my fork results in what I would expect: