Skip to content

Comments

Feature/ecs alerts#598

Merged
jnathangreeg merged 4 commits intomainfrom
feature/ecs-alerts
Jan 26, 2026
Merged

Feature/ecs alerts#598
jnathangreeg merged 4 commits intomainfrom
feature/ecs-alerts

Conversation

@jnathangreeg
Copy link
Contributor

@jnathangreeg jnathangreeg commented Jan 23, 2026

Summary by CodeRabbit

  • New Features
    • Added ECS (Elastic Container Service) support to runtime alert detection, enabling better identification and validation of incidents from ECS-based infrastructure.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 23, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

The change extends the runtime incidents system to support AWS ECS by introducing a new RuntimeAlertECSDetails structure, integrating it into RuntimeAlert, adding AlertSourcePlatformECS as a detection option, and updating validation logic to handle ECS-based alerts.

Changes

Cohort / File(s) Summary
ECS Alert Support
armotypes/runtimeincidents.go
Added new RuntimeAlertECSDetails struct with ECS-specific fields (cluster, service, task, container, image); added RuntimeAlertECSDetails field to RuntimeAlert; introduced AlertSourcePlatformECS enum value; extended GetAlertSourcePlatform() to detect ECS alerts via TaskARN/ClusterARN; updated validation logic to handle ECS as a recognized alert source platform alongside EC2/Cloud/Unknown

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A new platform joins the fray,
ECS alerts now find their way,
With clusters, tasks, and containers bright,
Our detection logic shines more light,
From EC2 to ECS we leap,
Runtime incidents run deep! 🚀

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Feature/ecs alerts' is vague and uses generic pattern-based naming rather than describing the actual change. Use a more specific title that describes the actual change, such as 'Add ECS-specific alert details structure and source detection' or 'Support ECS alerts in runtime incident models'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]

This comment was marked as resolved.

@jnathangreeg jnathangreeg merged commit 68f64af into main Jan 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants