Skip to content

Comments

Add ResourceGroup field to CloudMetadata for Azure support#600

Merged
slashben merged 1 commit intomainfrom
add-azure-resourcegroup
Jan 27, 2026
Merged

Add ResourceGroup field to CloudMetadata for Azure support#600
slashben merged 1 commit intomainfrom
add-azure-resourcegroup

Conversation

@slashben
Copy link
Member

@slashben slashben commented Jan 27, 2026

Summary

  • Add ResourceGroup field to CloudMetadata struct to capture Azure Resource Group information
  • This enables RuntimeAlerts from Azure Kubernetes nodes to include resource group data

Changes

  • Added ResourceGroup field with JSON/BSON tags to CloudMetadata struct in armotypes/runtimeincidents.go

Context

This field will be populated by:

  • Kubernetes node spec providerID (format: azure:///subscriptions/{sub}/resourceGroups/{rg}/providers/...)
  • Azure IMDS metadata endpoint (resourceGroupName)

This is the first phase of a multi-repo change to add Azure Resource Group support to RuntimeAlerts.

Summary by CodeRabbit

  • New Features
    • Added support for capturing Azure Resource Group information in cloud metadata.

✏️ Tip: You can customize this high-level summary in your review settings.

Add ResourceGroup field to CloudMetadata struct to capture Azure Resource Group information. This field will be populated from Kubernetes node spec providerID or Azure IMDS metadata.
Signed-off-by: Ben <ben@armosec.io>
@slashben slashben requested a review from matthyx January 27, 2026 09:23
@coderabbitai
Copy link

coderabbitai bot commented Jan 27, 2026

📝 Walkthrough

Walkthrough

A new ResourceGroup field of type string is added to the CloudMetadata struct in armotypes/runtimeincidents.go. The field includes JSON and BSON serialization tags with omitempty options and stores Azure Resource Group information.

Changes

Cohort / File(s) Summary
CloudMetadata struct expansion
armotypes/runtimeincidents.go
Added ResourceGroup string field with json:"resource_group,omitempty" and bson:"resource_group,omitempty" tags to capture Azure Resource Group data

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A new field hops into view,
ResourceGroup, shiny and new!
Azure's home, stored with care,
Metadata blooms everywhere! 🌿

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately and clearly describes the main change: adding a ResourceGroup field to CloudMetadata struct for Azure support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@slashben slashben merged commit 46ecef9 into main Jan 27, 2026
4 checks passed
@slashben slashben deleted the add-azure-resourcegroup branch January 27, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants