Skip to content

Comments

AWS resource hash calculation#601

Merged
amirmalka merged 1 commit intomainfrom
aws-resource-hash-util
Jan 28, 2026
Merged

AWS resource hash calculation#601
amirmalka merged 1 commit intomainfrom
aws-resource-hash-util

Conversation

@amirmalka
Copy link
Contributor

@amirmalka amirmalka commented Jan 28, 2026

Summary by CodeRabbit

  • New Features
    • Introduced enhanced AWS resource identification infrastructure to improve resource tracking, management, and accessibility across the platform. The backend improvements provide a more robust foundation for identifying and organizing AWS resources, supporting better system-wide resource handling and integration capabilities.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Amir Malka <amirm@armosec.io>
@coderabbitai
Copy link

coderabbitai bot commented Jan 28, 2026

📝 Walkthrough

Walkthrough

A new utility function CalcAwsResourceHashFNV was added to the identifiers package. The function accepts a customer GUID and AWS resource ARN, concatenates them with a forward slash, lowercases the result, and returns the computed FNV hash.

Changes

Cohort / File(s) Summary
Hash utility function addition
identifiers/utils.go
Added exported function CalcAwsResourceHashFNV(customerGUID, resourceArn string) string that combines customer GUID and resource ARN, lowercases the combined string, and returns its FNV hash

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A hashing function, simple and keen,
Combines the GUID with ARN so clean,
Lowercased and FNV'd with care,
AWS resources are easier to bear! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: adding a new function for AWS resource hash calculation.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@amirmalka amirmalka merged commit aadb86f into main Jan 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants