feat: better support for 'x-kubernetes-preserve-unknown-fields' #82
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unknown-fields also allowing arrays and everything else
…nown-fields to allow all JSON values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey again :)
thanks for merging the last fix so quickly and thanks for the project in general!
I just found another little edge-case in the crd-generator, when generating crds for kyverno and then installing kyverno-policies helm chart.
They use fields which have
x-kubernetes-preserve-unknown-fieldswithout any type hint extensively. In this case the generator still expected an attrset in nix, but it can per spec be any json value. In kyverno it was given an array, which led to an error. Now it's justtypes.unspecifiedwhenx-kubernetes-preserve-unknown-fieldsis given without any type hints.