Make plugin work with segment.io 3.0.0#16
Open
karolk wants to merge 6 commits intoarnaudbreton:masterfrom
Open
Make plugin work with segment.io 3.0.0#16karolk wants to merge 6 commits intoarnaudbreton:masterfrom
karolk wants to merge 6 commits intoarnaudbreton:masterfrom
Conversation
do not rely on initialized flag, which is now deprecated
…is avoid keeping events stuck in the queue until the next segmentio method call
flush the queue of pending events when analytics script is loaded. Th…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code no longer tries to mock the analytics object, because when it happens the mock object doesn't get assigned the 'initialized' property correctly. This is also a deprecated flag in segmentio. Instead it uses the presence of analytics as signal to resend the queue of events and start proxying them to the library.