Skip to content

Fix ScrollReveal Flickering image #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yyatiko wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix ScrollReveal Flickering image #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion _includes/head.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@
<link rel="manifest" href="/manifest.json">
<link rel="mask-icon" href="/safari-pinned-tab.svg" color="#5bbad5">
<meta name="theme-color" content="#ffffff">
<link rel="stylesheet" href="{{ "/assets/css/style.css" | prepend: site.baseurl }}">
<link rel="stylesheet" href="{{ "/assets/css/style.css" | prepend: site.baseurl }}">
<script src="https://unpkg.com/scrollreveal"></script>
7 changes: 5 additions & 2 deletions _layouts/project.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
<!DOCTYPE html>
<html lang="en">

<head>
<title>{{ site.author }} / {{ page.project.title }}</title>
<meta name="author" content="{{ site.author }}">
<meta name="description" content="{{ page.content | strip_html | strip_newlines }}">
<meta name="keywords" content="{{ page.meta.keywords }}">
{% include head.html %}
</head>

<body>
{% include header.html %}
<main class="content">
Expand All @@ -31,7 +33,7 @@ <h1>
<aside>
<ul>
{% for image in page.images %}
<li>
<li class="load-hidden">
<img src="{{ image.url | prepend: site.baseurl }}" alt="{{ image.alt }}" />
</li>
{% endfor %}
Expand All @@ -58,8 +60,9 @@ <h2>{{ page.next.project.title }}</h2>
</main>
{% include footer.html %}
<script src="{{ "/assets/scripts/vendor/jquery-1.12.4.min.js" | prepend: site.baseurl }}"></script>
<script src="{{ "/assets/scripts/vendor/scrollreveal.min.js" | prepend: site.baseurl }}"></script>
<!-- <script src="{{ "/assets/scripts/vendor/scrollreveal.min.js" | prepend: site.baseurl }}"></script> -->
<script src="{{ "/assets/scripts/vendor/sticky-kit.min.js" | prepend: site.baseurl }}"></script>
<script src="{{ "/assets/scripts/project.js" | prepend: site.baseurl }}"></script>
</body>

</html>
3 changes: 2 additions & 1 deletion assets/css/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@
@import "fonts";
@import "core";
@import "layout";
@import "syntax";
@import "syntax";
@import "scrollreveal";
3 changes: 3 additions & 0 deletions assets/scss/_scrollreveal.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
html.sr .load-hidden {
visibility: hidden;
}
23 changes: 13 additions & 10 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,15 @@
---
<!DOCTYPE html>
<html lang="en">

<head>
<title>{{ site.author }} / {{ site.tagline }}</title>
<meta name="author" content="{{ site.author }}">
<meta name="description" content="{{ site.description }}">
<meta name="keywords" content="{{ site.keywords }}">
{% include head.html %}
</head>

<body>
{% include header.html %}
<main class="content">
Expand All @@ -23,22 +25,23 @@ <h2>About me.</h2>
<h2>Projects I have worked on.</h2>
<ul class="projects-list">
{% for item in site.categories.projects reversed %}
<li>
<a href="{{ item.url | prepend: site.baseurl }}">
<div class="img-wrapper">
<img src="{{ item.project.logo | prepend: site.baseurl }}" alt="{{ item.project.title }}" />
</div>
<span class="h2">{{ item.project.type }}</span>
<h3>{{ item.project.title }}</h3>
</a>
</li>
<li class="load-hidden">
<a href="{{ item.url | prepend: site.baseurl }}">
<div class="img-wrapper">
<img src="{{ item.project.logo | prepend: site.baseurl }}" alt="{{ item.project.title }}" />
</div>
<span class="h2">{{ item.project.type }}</span>
<h3>{{ item.project.title }}</h3>
</a>
</li>
{% endfor %}
</ul>
</div>
</section>
</main>
{% include footer.html %}
<script src="{{ "/assets/scripts/vendor/scrollreveal.min.js" | prepend: site.baseurl }}"></script>
<!-- <script src="{{ "/assets/scripts/vendor/scrollreveal.min.js" | prepend: site.baseurl }}"></script> -->
<script src="{{ "/assets/scripts/home.js" | prepend: site.baseurl }}"></script>
</body>

</html>