Skip to content

Comments

Add clj-kondo config#2

Merged
aroemers merged 3 commits intomasterfrom
feature/clj-kondo-config
Jan 16, 2025
Merged

Add clj-kondo config#2
aroemers merged 3 commits intomasterfrom
feature/clj-kondo-config

Conversation

@aroemers
Copy link
Owner

@aroemers aroemers commented Nov 6, 2024

Proposal for #1

@aroemers aroemers self-assigned this Nov 6, 2024
@aroemers aroemers mentioned this pull request Nov 6, 2024
@piranha
Copy link

piranha commented Nov 14, 2024

Wow this is way more efficient than what I did; I need to try this out, but I suspect you already did? 😁

@aroemers
Copy link
Owner Author

... but I suspect you already did?

I linted this project itself, which validated the states and defstates in the tests. I don't have access to a project using redelay currently. So, if you have, validating this change will certainly help!

@piranha
Copy link

piranha commented Nov 15, 2024

One thing that's lacking is that jar does not include clj-kondo config in the correct path, see clj-kondo docs on that.

For an example, look at better-cond.

@aroemers
Copy link
Owner Author

Thanks for checking, it is now included in the JARs resources.

@piranha
Copy link

piranha commented Nov 18, 2024

Something is still not working, not sure why, will check later today.

P.S. You've got core.clj~ in the diffs here :)

@piranha
Copy link

piranha commented Nov 21, 2024

Oh, everything works, if I do this. Weird, I thought that's automated. But it works. :)

@aroemers aroemers force-pushed the feature/clj-kondo-config branch from c48a16e to 01ad3e8 Compare January 16, 2025 20:48
@aroemers aroemers merged commit 5d854b9 into master Jan 16, 2025
1 check failed
@aroemers aroemers deleted the feature/clj-kondo-config branch January 16, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants