Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR re-enables the Windows build and integration test jobs in CI, which were temporarily disabled on
mainbecause they kept failing the pipeline.Why this is hard
Getting ARO to build and pass tests on Windows has been a persistent challenge due to several compounding issues:
SetConsoleCtrlHandleror similar alternatives, which means platform-specific codepaths.dlopen/dlsymon Unix but needsLoadLibrary/GetProcAddresson Windows. The conditional compilation paths exist but are undertested.skip-on-windowshints, but getting the right set of skips without masking real failures is trial and error.aro build(native compilation) is not guaranteed. Path handling (\vs/), temp directory locations, and shell differences (PowerShell vs cmd) add friction to every CI step.Help wanted
If anyone has experience with Swift on Windows or wants to help debug the CI failures, contributions are very welcome. The pipeline will run on this branch so failures are visible without blocking
main.Key areas where help would be useful:
aro build) working with LLVM on Windowstest.hintfiles accordingly