@ashfurrow => [WIP] [Pods] Migrate to CocoaPods frameworks #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Sweet 👌🏿 |
Contributor
Author
|
OK, this is probably good. Though I expect it to fail, because the font is a newer font, which has a pretty significant difference on tracking between letters. Ideally we should have a webpage we can see the difference on when it reds. |
Contributor
|
Assigning this to @ashfurrow for during his Q&A time. |
alloy
changed the title
Contributor
|
Is this still a WIP? It needs a merge if we want to continue going with this branch. |
Contributor
Author
|
closing in favour of #520 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't prime-time yet, but I wanted to throw a few hours to get a sense what it's like to migrate. I was pleasantly surprised that I was 90% done within 20 minutes. That was mostly updating CocoaLumberjack and making my own fork of AFNetworking with compiler-time checking for System Configuration removed.
WIP because fonts.