-
Notifications
You must be signed in to change notification settings - Fork 149
fix(checkout): fallback to artwork image if artworkVersion default image is null #16610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| justifyContent="space-between" | ||
| > | ||
| <RouterLink flex={0} to={artworkPath} target="_blank"> | ||
| <Image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's conditionally render the image if imageUrl is not available as well
| image { | ||
| resized(width: 185, height: 138) { | ||
| url | ||
| resized(height: 200, version: ["square"]) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only want the square image for the collapsible order summary. The review step one should display the artwork in its original shape.
#5989 Bundle Size — 9.54MiB (+0.08%).5053ddb(current) vs 1238930 main#5987(baseline) Warning Bundle contains 34 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
Bundle analysis report Branch ansor4/checkout-backup-image Project dashboard Generated by RelativeCI Documentation Report issue |
The type of this PR is: FIX
This PR solves EMI-3028
Description
urlfield instead of just theresizedfield onartworkVersionto check for null URLsartworklevel in case URLs fromartworkVersionare null.Before:

After: