Skip to content

Conversation

@ansor4
Copy link
Member

@ansor4 ansor4 commented Jan 15, 2026

The type of this PR is: FIX

This PR solves EMI-3028

Description

  • Fetch additional url field instead of just the resized field on artworkVersion to check for null URLs
  • Make an additional query to fetch image urls on the artwork level in case URLs from artworkVersion are null.
  • Make those changes for both Order2CollapsibleOrderSummary.tsx (breakpoint view) and Order2ReviewStep.tsx (full width view)
  • Create a new test file for Order2ReviewStep.tsx

Before:
Screenshot 2026-01-14 at 6 09 15 PM

Screenshot 2026-01-14 at 6 09 21 PM

After:

Screenshot 2026-01-14 at 6 08 52 PM Screenshot 2026-01-14 at 6 08 58 PM

@ansor4 ansor4 requested a review from rquartararo January 15, 2026 02:11
@ansor4 ansor4 self-assigned this Jan 15, 2026
justifyContent="space-between"
>
<RouterLink flex={0} to={artworkPath} target="_blank">
<Image
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's conditionally render the image if imageUrl is not available as well

image {
resized(width: 185, height: 138) {
url
resized(height: 200, version: ["square"]) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only want the square image for the collapsible order summary. The review step one should display the artwork in its original shape.

@relativeci
Copy link

relativeci bot commented Jan 15, 2026

#5989 Bundle Size — 9.54MiB (+0.08%).

5053ddb(current) vs 1238930 main#5987(baseline)

Warning

Bundle contains 34 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#5989
     Baseline
#5987
Regression  Initial JS 3.71MiB(+0.05%) 3.71MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 42.54% 40.85%
No change  Chunks 102 102
No change  Assets 105 105
No change  Modules 5955 5955
No change  Duplicate Modules 597 597
No change  Duplicate Code 4.14% 4.14%
No change  Packages 297 297
No change  Duplicate Packages 33 33
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#5989
     Baseline
#5987
Regression  JS 9.4MiB (+0.08%) 9.39MiB
No change  Other 144.17KiB 144.17KiB

Bundle analysis reportBranch ansor4/checkout-backup-imageProject dashboard


Generated by RelativeCIDocumentationReport issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants