feat(order2): payment step error handling #16612
Conversation
| const handlePaymentElementError = useCallback( | ||
| // do not setStepErrorMessage since the error is being handled by the PaymentElement | ||
| (error: StripeError) => { | ||
| paymentElementRef.current?.scrollIntoView({ |
There was a problem hiding this comment.
👍 scrolling to the entire payment element UI should be sufficient!
src/Apps/Order2/Routes/Checkout/Components/PaymentStep/Order2PaymentForm.tsx
Outdated
Show resolved
Hide resolved
| if (submitError) { | ||
| logger.error(submitError) | ||
| handleError(submitError) | ||
| handlePaymentElementError(submitError) |
There was a problem hiding this comment.
I think elements.submit() raises validation errors, but I'm not 100% sure if Stripe would always highlight a particular input. I wonder if there would be a case where we do still want to show the error message in our UI. Non-blocking if we can't easily verify.
There was a problem hiding this comment.
Let me try to verify in the docs. I'll merge this as is for now.
starsirius
left a comment
starsirius
left a comment
There was a problem hiding this comment.
Have a question about errors from elements.submit(); otherwise LGTM!
#6023 Bundle Size — 9.53MiB (+2.01%).09bae0a(current) vs 4af6329 main#6021(baseline) Warning Bundle contains 34 duplicate packages – View duplicate packages Warning Bundle introduced 2 new packages: @swc/helpers, regenerator-runtime – View changed packages Bundle metrics
|
| Current #6023 |
Baseline #6021 |
|
|---|---|---|
 Initial JS |
3.71MiB(+1.39%) |
3.66MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
100% |
40.9% |
| Chunks |
102(+3.03%) |
99 |
| Assets |
105(+2.94%) |
102 |
| Modules |
5956(+0.74%) |
5912 |
| Duplicate Modules |
597(+6.61%) |
560 |
| Duplicate Code |
4.14%(+8.38%) |
3.82% |
| Packages |
297(+0.68%) |
295 |
| Duplicate Packages |
33 |
33 |
Bundle size by type 2 changes 2 regressions
| Current #6023 |
Baseline #6021 |
|
|---|---|---|
| JS |
9.39MiB (+1.99%) |
9.2MiB |
| Other |
144.17KiB (+3.29%) |
139.59KiB |
Bundle analysis report Branch rquartararo/payment-errors Project dashboard
Generated by RelativeCI Documentation Report issue
The type of this PR is: Feat/Refactor
This PR solves EMI-3019
Description
Screen.Recording.2026-01-14.at.3.44.40.PM.mov