feat: consolidate artist app meta tags #16616
Conversation
#6017 Bundle Size — 9.53MiB (+2.07%).6fcbe65(current) vs c74b2b5 main#6013(baseline) Warning Bundle contains 34 duplicate packages – View duplicate packages Warning Bundle introduced 2 new packages: @swc/helpers, regenerator-runtime – View changed packages Bundle metrics
|
| Current #6017 |
Baseline #6013 |
|
|---|---|---|
 Initial JS |
3.71MiB(+1.42%) |
3.66MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
100% |
37.71% |
| Chunks |
102(+3.03%) |
99 |
| Assets |
105(+2.94%) |
102 |
| Modules |
5955(+0.73%) |
5912 |
| Duplicate Modules |
597(+6.61%) |
560 |
| Duplicate Code |
4.15%(+8.92%) |
3.81% |
| Packages |
297(+0.68%) |
295 |
| Duplicate Packages |
33 |
33 |
Bundle size by type 2 changes 2 regressions
| Current #6017 |
Baseline #6013 |
|
|---|---|---|
| JS |
9.39MiB (+2.06%) |
9.2MiB |
| Other |
144.17KiB (+3.29%) |
139.59KiB |
Bundle analysis report Branch iskounen/feat/consolidate-artist... Project dashboard
Generated by RelativeCI Documentation Report issue
| const blurb = artist.biographyBlurbPlain?.text?.substring(0, 70) || "" | ||
| return blurb ? `${baseDescription} ${blurb}` : baseDescription | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm not opposed to this living in Force — it's hard for me to remember the logic of why it was split out — but we should tear down the fields in Metaphysics if that's the case. Provided we ensure other projects aren't using them: https://github.com/artsy/metaphysics/blob/main/src/schema/v2/artist/meta.ts — I can't imagine Eigen has a use?
There was a problem hiding this comment.
I searched around our other repos and didn't find any clients using this, so it's on the chopping block.
anandaroop
left a comment
anandaroop
left a comment
There was a problem hiding this comment.
Looks good to me, with one minor change below.
This PR modifies ArtistMeta so that it can provide the correct set of
<title>,<meta>and<link>tags for each of the artist page sub-routes: /articles, /cv, /series and /shows.match.location.pathnameto determine the page that it is being rendered on, and renders the correct title, description and canonical URL for each one.metaGraphQL field and starts managing the titles and descriptions for each sub-route for itself.