Skip to content

Conversation

@wfindley
Copy link

No description provided.

@gsaslis
Copy link
Collaborator

gsaslis commented Dec 11, 2015

yep this looks like a pretty straightforward fix... 👍

@gsaslis
Copy link
Collaborator

gsaslis commented Dec 11, 2015

@wfindley do you feel confident extending the tests to cover this case?

@wfindley
Copy link
Author

What needs extending? It seems to me that the current tests are adequate.

@gsaslis
Copy link
Collaborator

gsaslis commented Dec 12, 2015

well, if they were indeed adequate - there should be one that is failing exactly because of the bug you've brought up here ;)
So we need a new (unit) test that confirms that the /etc/init.d/ file is named after the app_name (and not always 'jetty' ;) )

@wfindley
Copy link
Author

Oh, yeah I can do that. Chefspec?
On Dec 12, 2015 8:59 AM, "Yorgos Saslis" notifications@github.com wrote:

well, if they were indeed adequate - there should be one that is failing
exactly because of the bug you've brought up here ;)
So we need a new (unit) test that confirms that the /etc/init.d/ file is
named after the app_name (and not always 'jetty' ;) )


Reply to this email directly or view it on GitHub
#8 (comment)
.

@gsaslis
Copy link
Collaborator

gsaslis commented Dec 14, 2015

yep - that would be cool ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants