Fix memory leak. #1
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you know, plain C has not RAII, so the structure created in
tinycurl/tinycurl.cpp
Line 29 in 00b89ff
Is never deallocated by the underlying library. I opted in this pull request to let this structure as a private member and clean in the destructor:
https://github.com/phoemur/tinycurl/blob/b95a68f84ecc171638d00b5de688869f9d7493f3/tinycurl.cpp#L24
Also improved the resource creation in the constructor and better cleanup in this pull request.
This small change seems to make a huge difference, as you can see:
Valgrind before changes:
`
==3320==
`
Valgrind After changes:
`
==3419==
I could not eliminate all leaks, though going from 96,824 to 528 bytes in use at exit semmed worth a pull request.
Thanks for your attention