Conversation
Co-authored-by: kylegodbey <5806808+kylegodbey@users.noreply.github.com>
|
@copilot I actually want to have numpy 2.0.0 support as a requirement. I see that 3.9 can be used for numpy 2.0 |
Co-authored-by: kylegodbey <5806808+kylegodbey@users.noreply.github.com>
Updated to keep numpy ^2.0.0 as requested. You're correct that numpy 2.0.0 supports Python 3.9+. Also restored the other dependencies to their original versions where compatible with Python 3.9 (scipy ^1.11.0, matplotlib ^3.7.0, scikit-learn ^1.3.0, tables ^3.9.0). All tests pass. (a18849d) |
There was a problem hiding this comment.
Pull request overview
This PR expands Python version support from 3.11+ to 3.9+ by correcting non-existent dependency versions and updating CI workflows.
Changes:
- Fixed critical nonexistent dependency versions (scipy 1.15.0 → 1.11.0, tables 3.10.2 → 3.9.0)
- Broadened Python requirement from ^3.11 to ^3.9
- Added Python 3.9 and 3.10 to CI test matrices
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Updated Python requirement to ^3.9 and corrected nonexistent dependency versions to valid versions compatible with Python 3.9+ |
| poetry.lock | Regenerated lock file with Python 3.9-compatible dependencies and version markers |
| .github/workflows/deploy.yml | Added Python 3.9 and 3.10 to test matrix |
| .github/workflows/ci-cd.yml | Added Python 3.9 and 3.10 to test matrix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Package was pinned to Python ^3.11, unnecessarily excluding users on 3.9 and 3.10.
Changes
No code changes required—package already compatible with Python 3.9 (no pattern matching, union operators, or other 3.10+ features).
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.