fix: refactor package parsing and fix command execution

[l50]

Problem:

• Package installation failed with "invalid char ' '" errors due to improper whitespace handling
• Complex sed regex patterns were fragile and hard to maintain
• Duplicated environment setup code for go install vs go get

Solution:

• Simplified comment parsing using bash pattern matching for full-line comments
• Added explicit whitespace trimming with xargs after removing inline comments
• Consolidated go command execution using array for proper argument handling
• Use separate variable for package installation to avoid mutating display name

Changes:

• Replace complex sed patterns with simpler, more robust parsing logic
• Use bash array for go_cmd to properly handle "get -u" as separate arguments
• Add stderr redirection (2>&1) for proper error capture
• Fix typo: "donwload" -> "download"
• Consolidate duplicate GOROOT/GOPATH/PATH setup

Impact:

• Fixes installation failures for packages in .default-golang-pkgs
• Supports comments and various whitespace formatting in package files
• More maintainable code
• Closes Issue: Default Go packages fail to install with "invalid char ' '" error #163

---

Note

Refactors bin/install to robustly parse default package entries and unify go install/get execution with shared env and proper argument handling.

• bin/install:
  • Package parsing: Skip empty/comment lines via bash pattern; strip inline comments and trim whitespace; avoid mutating display name.
  • Command execution: Use go_cmd array and pkg_to_install (append @latest when needed); consolidate env setup and invoke go once; redirect stdout/stderr to /dev/null 2>&1.
  • Go version handling: Retain install for >=1.16, get -u otherwise using array args.
  • Misc: Fix typo "donwload" -> "download".

^{Written by Cursor Bugbot for commit e164f0f. This will update automatically on new commits. Configure here.}

[l50]

Anything I can do to unblock this?

[smorimoto]

bugbot run

[cursor]

✅ Bugbot reviewed your changes and found no bugs!

---

[l50]

How we looking?

[cursor]

✅ Bugbot reviewed your changes and found no bugs!

---