Add function for calling round on polygon points
#20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reweeden
force-pushed
the
rew/round-polygon-points
branch
from
f920428 to
14d0a8d
Compare
reweeden
requested review from
Cameronsplaze,
benbart,
gjclark,
mattp0 and
mckadesorensen
gjclark
approved these changes
Dec 24, 2025
Contributor
gjclark
left a comment
gjclark
left a comment
There was a problem hiding this comment.
I'll approve here. I think we all agree with Cameron's comment about shadowing the outer function's name on round_points.
reweeden
force-pushed
the
rew/round-polygon-points
branch
from
14d0a8d to
55cf552
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From ARIA legacy bugfix PR-7235. Allows doing rounding in the actual polygon processing pipeline so that post-rounding issues of duplicate points can be cleaned up.
Pull Request Checklist
I have: