feat: enhance OAuth handling with improved error logging and state management#108
Merged
brionmario merged 3 commits intoasgardeo:mainfrom Jul 15, 2025
Merged
Conversation
pavinduLakshan
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces enhancements to the OAuth handling in the
@asgardeo/nextjspackage, focusing on improved error logging, state management, and code clarity. Key changes include replacingconsolestatements with a centralizedlogger, addressing React 18 strict mode issues, and refining token handling logic.OAuth Error Logging Improvements:
console.errorstatements withlogger.errorfor consistent logging inAsgardeoProvider.tsx. This includes logging OAuth errors and authentication failures with more descriptive messages. [1] [2]handleOAuthCallbackAction.ts. [1] [2]handleOAuthCallbackAction.ts.React 18 Strict Mode Compatibility:
reRenderCheckRefinAsgardeoProvider.tsxto prevent race conditions caused by React 18's strict mode remounting behavior.Token Handling Refinements:
id_tokenandaccess_tokeninhandleOAuthCallbackAction.tsto accommodate variations in property names (idToken,accessToken).Codebase Maintenance:
index.tswith a note to remove it once documentation is live.loggerimport inhandleOAuthCallbackAction.tsfor centralized logging.Related Issues
@asgardeo/react&@asgardeo/nextjs#81Related PRs
Checklist
Security checks