Skip to content

feat(i18n): add Hindi (hi-IN) language support#175

Closed
adityagupta0251 wants to merge 0 commit intoasgardeo:mainfrom
adityagupta0251:feat/add-hi-IN-language-support
Closed

feat(i18n): add Hindi (hi-IN) language support#175
adityagupta0251 wants to merge 0 commit intoasgardeo:mainfrom
adityagupta0251:feat/add-hi-IN-language-support

Conversation

@adityagupta0251
Copy link
Contributor

@adityagupta0251 adityagupta0251 commented Sep 26, 2025

Purpose

Add Hindi (hi-IN) language support to the Asgardeo JavaScript SDK.

Changes

  • Added src/i18n/hi-IN.ts with Hindi translations.

@adityagupta0251
Copy link
Contributor Author

@brionmario Now , checkout this.. Hope After some trouble this could be fine since Thanks for recomending contribution guide to learn from it now if again there or Key points that i missed please guide us..
Thanks for appreciating me❤️🙌!

@adityagupta0251
Copy link
Contributor Author

@brionmario Thank you for giving me a chance 🙌 Check out my work

@brionmario
Copy link
Member

brionmario commented Sep 29, 2025

@adityagupta0251 Thanks for the updates.

  1. I noticed that the hi-IN file is missing some block comments when comparing with en-US.
    Can you please add them back?
    IMO, it would be easy to simply take a copy of the en-US file and only translate the values.
Screenshot 2025-09-29 at 15 30 43
  1. Also, seems like the latest commits doesn't follow out standard conventional git commits pattern. (https://github.com/brionmario/javascript/blob/refactor-i18n/CONTRIBUTING.md#commit-message-guidelines).
    Can you please revert the commits and push again.

@adityagupta0251 adityagupta0251 force-pushed the feat/add-hi-IN-language-support branch from c8cab99 to ef57938 Compare September 29, 2025 10:17
@adityagupta0251
Copy link
Contributor Author

@brionmario Done all things

@brionmario
Copy link
Member

brionmario commented Sep 29, 2025

@brionmario Done all things

Great now the block comment issue is fixed.
But there seems to be a few more issues.
I've added inline comments.

I think the issue might be that ESLint & Prettier plugins are not installed properly.

Lets do these changes and we are good to merge.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Install ESLint and Prettier VSCode plugins and do a autofix.

ctrl+shifp+p -> ESLint: Fix all auto-fixable problems
Screenshot 2025-09-29 at 19 20 23

*/

export {default as en_US} from './en-US';
export {default as en_US} from './en-US'; No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to change this file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to change this file

@adityagupta0251 adityagupta0251 force-pushed the feat/add-hi-IN-language-support branch from ef57938 to 9275cad Compare September 29, 2025 14:28
@adityagupta0251 adityagupta0251 deleted the feat/add-hi-IN-language-support branch September 29, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants