Skip to content

feat(i18n): add Hindi (hi-IN) language support#183

Closed
adityagupta0251 wants to merge 0 commit intoasgardeo:mainfrom
adityagupta0251:feat/add-hi-IN-language-support
Closed

feat(i18n): add Hindi (hi-IN) language support#183
adityagupta0251 wants to merge 0 commit intoasgardeo:mainfrom
adityagupta0251:feat/add-hi-IN-language-support

Conversation

@adityagupta0251
Copy link
Contributor

feat(i18n): add Hindi (hi-IN) language support
📖 Description
Current Limitation

The Asgardeo JavaScript SDK currently does not support Hindi (हिन्दी – hi-IN).
Users preferring Hindi cannot see translated UI components, which limits accessibility for Hindi-speaking users.

Suggested Improvement

This PR adds Hindi (hi-IN) language support to the @asgardeo/i18n package.

⚙️ Implementation Details

New locale file:
packages/i18n/src/locales/hi-IN.ts

Translations provided for all UI components, including:

Sign-in / Sign-out

Dashboard

Profile

Other common authentication flows

Structure aligned with en-US.ts (including block comments).

Updated i18n configuration to register hi-IN as a supported locale.

Documentation updated to reference hi-IN.

✅ Checklist

Verified translations are accurate and culturally appropriate

Locale file structured with block comments aligned to en-US.ts

Package builds successfully with new locale

Confirmed no duplicate keys exist in translations

📦 Related Packages

@asgardeo/react

@asgardeo/nextjs

🙏 Notes for Reviewers

Please validate that translations render correctly in UI components.

Feedback on phrasing, terminology, or cultural accuracy is highly appreciated.

@adityagupta0251
Copy link
Contributor Author

@brionmario Hope it finds you well 🍀

@brionmario
Copy link
Member

brionmario commented Sep 29, 2025

@brionmario Hope it finds you well 🍀

Still the formatting is not aligning to the existing coding style.

Have you installed ESLint & Prettier plugins and tried fixing the lint issues?
As mentioned in the previous PR, this can be done easily with VSCode.

cmd+shift+p -> ESLint: Fix all

Screenshot 2025-09-29 at 21 31 28

Please have a look at the existing en-US: https://github.com/asgardeo/javascript/blob/6f49213b60f51a85109de66dc0d12a25668bca93/packages/javascript/src/i18n/en-US.ts

Also, lets keep the existing PR template: https://github.com/asgardeo/javascript/blob/main/.github/pull_request_template.md


/* eslint-disable sort-keys */

import { I18nTranslations, I18nMetadata, I18nBundle } from "../models/i18n";
Copy link
Member

@brionmario brionmario Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in #183 (comment), these can be auto-fixed.

Suggested change
import { I18nTranslations, I18nMetadata, I18nBundle } from "../models/i18n";
'elements.buttons.signIn': 'साइन इन',
Suggested change
import { I18nTranslations, I18nMetadata, I18nBundle } from "../models/i18n";
import {I18nTranslations, I18nMetadata, I18nBundle} from "../models/i18n";

/* |---------------------------------------------------------------| */

/* Buttons */
"elements.buttons.signIn": "साइन इन",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use single quotes.
As mentioned in #183 (comment), these can be auto-fixed.

Suggested change
"elements.buttons.signIn": "साइन इन",
'elements.buttons.signIn': 'साइन इन',

@adityagupta0251 adityagupta0251 force-pushed the feat/add-hi-IN-language-support branch from 1b4e362 to 9275cad Compare September 29, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants