fix(react): update input variant logic to handle password fields correctly#241
Merged
brionmario merged 3 commits intoasgardeo:mainfrom Nov 11, 2025
Merged
Conversation
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
NipuniBhagya
approved these changes
Nov 11, 2025
JayaShakthi97
approved these changes
Nov 11, 2025
DilshanSenarath
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request refines how input fields are transformed into UI components for both the sign-in and sign-up flows. The main change is shifting the logic for determining input variants to rely solely on the input type, with a workaround added to handle password fields when their type is incorrectly specified as "string". This improves consistency and prepares for future improvements.
Input variant determination logic:
getInputVariantin bothSignInandSignUptransformers to use only the input type for deciding the component variant, removing checks based on the field name. [1] [2]Password field handling workaround:
convertSimpleInputToComponentfunctions, added logic to set the field type to "password" if the field name contains "password" and the type is "string", ensuring correct handling of password fields until a broader fix is implemented. [1] [2]Related Issues
componentrelated metadata to theFlowAPIs thunder#725Related PRs
Checklist
Security checks