chore: improve SignIn & SignUp styling#243
Merged
brionmario merged 4 commits intoasgardeo:mainfrom Nov 14, 2025
Merged
Conversation
…BaseSignUp components
…logic and add showLogo, showTitle, and showSubtitle props
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
DonOmalVindula
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request refactors the Sign In UI components to improve flexibility, error handling, and consistency between component-driven and non-component-driven implementations. The most significant changes include the addition of new props to control the display of the logo, title, and subtitle, a migration to a unified error message handling system, and a general cleanup of redundant code and props.
Component flexibility and UI consistency:
showLogo,showTitle, andshowSubtitleprops to both component-driven and non-component-drivenBaseSignIncomponents, allowing consumers to control the visibility of these elements for greater UI customization. [1] [2] [3] [4] [5]BaseSignInContentto conditionally display the logo, title, and subtitle based on these new props.Error handling improvements:
extractErrorMessagetransformer and the flow message system, removing the localerrorstate and related props fromBaseSignInand its render props. This ensures errors are displayed consistently and are easier to manage. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Styling and layout adjustments:
BaseSignIn.styles.tsto improve layout, including changes to margins and alignment for logo, header, subtitle, and flow messages containers. [1] [2] [3]non-component-driven/BaseSignIn.styles.tsfile and updated imports to use the shared styles for consistency. [1] [2]Code cleanup and minor improvements:
SignIn.tsxfor clarity. [1] [2]These changes collectively enhance the modularity, maintainability, and user experience of the Sign In components.
Related Issues
asgardeo/thunderruntime #212@asgardeo/react&@asgardeo/nextjs#81Related PRs
Checklist
Security checks