Fix social button rendering issue with Asgardeo v2 (Thunder) Flows API#300
Merged
brionmario merged 2 commits intoasgardeo:mainfrom Dec 19, 2025
Merged
Conversation
e569139 to
02f3343
Compare
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
DonOmalVindula
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request addresses a social button rendering issue in v2 and introduces several improvements to the embedded authentication flow, including support for a divider component, enhanced internationalization, and more robust handling of social login buttons. The changes also improve code clarity and maintainability by refining type definitions and component logic.
Authentication Flow Enhancements:
Dividercomponent type (EmbeddedFlowComponentType.Divider) for visual separation within authentication flows, and updated the component factory to render this divider appropriately. [1] [2]Internationalization (i18n) Improvements:
'elements.display.divider.or_separator'to the i18n model and provided translations for all supported languages (English, French, Hindi, Japanese, Portuguese (Brazil and Portugal), Sinhala, Tamil, Telugu). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Type and API Refinements:
embedded-flow-v2.ts, includingEmbeddedFlowComponentType,EmbeddedFlowActionVariant,EmbeddedFlowTextVariant, andEmbeddedFlowEventType, making the API clearer and easier to use. [1] [2] [3] [4]Bug Fixes:
Component Structure Improvements:
<form>element, improving semantic structure and accessibility.Related Issues
asgardeo/thunderruntime #212Related PRs
Checklist
Security checks