include tests/e2e in pnpm workspace for shared tooling#1086
include tests/e2e in pnpm workspace for shared tooling#1086NilukaSripalim wants to merge 3 commits intoasgardeo:mainfrom
Conversation
NilukaSripalim
requested review from
DonOmalVindula and
jeradrutnam
as code owners
There was a problem hiding this comment.
Pull request overview
This PR integrates the tests/e2e folder into the pnpm workspace to share tooling (linters, Prettier, etc.) across the project. The changes remove local tool dependencies, delete the standalone ESLint config and package-lock.json, and update the GitHub Actions workflow to use pnpm instead of npm for E2E test execution.
Changes:
- Added
tests/e2eto the pnpm workspace and updated dependencies to use shared tooling - Removed redundant configuration files (
eslint.config.mjs,package-lock.json) from the e2e directory - Updated GitHub Actions workflow to use pnpm for installing and running E2E tests
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tests/e2e/package.json |
Removed TypeScript ESLint plugins, downgraded ESLint to 8.57.1, added nx configuration for task orchestration |
tests/e2e/package-lock.json |
Deleted entire package-lock.json (2726 lines) as e2e is now part of pnpm workspace |
tests/e2e/eslint.config.mjs |
Removed standalone ESLint configuration file (52 lines) |
frontend/pnpm-workspace.yaml |
Added ../tests/e2e to workspace packages |
frontend/pnpm-lock.yaml |
Added e2e dependencies to the shared lockfile |
.github/workflows/pr-builder.yml |
Updated E2E job to use pnpm instead of npm, improved logging and error handling |
Files not reviewed (2)
- frontend/pnpm-lock.yaml: Language not supported
- tests/e2e/package-lock.json: Language not supported
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1086 +/- ##
==========================================
- Coverage 87.22% 87.20% -0.03%
==========================================
Files 535 535
Lines 36114 36114
Branches 1611 1611
==========================================
- Hits 31501 31492 -9
- Misses 2978 2985 +7
- Partials 1635 1637 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NilukaSripalim
added
the
skip-changelog
| "prettier": "3.4.2", | ||
| "typescript": "5.7.3" | ||
| "prettier": "3.6.2", | ||
| "typescript": "5.9.3" |
There was a problem hiding this comment.
The TypeScript version should be aligned with the workspace catalog. According to the pnpm-lock.yaml, the catalog specifies TypeScript 5.9.3, so this should use 'catalog:' to maintain consistency across the workspace.
| "typescript": "5.9.3" | |
| "typescript": "catalog:typescript" |
| TEST_USER_USERNAME: ${{ secrets.PLAYWRIGHT_TEST_USER_USERNAME || vars.PLAYWRIGHT_TEST_USER_USERNAME || 'testuser' }} | ||
| TEST_USER_PASSWORD: ${{ secrets.PLAYWRIGHT_TEST_USER_PASSWORD || 'admin' }} | ||
| PLAYWRIGHT_WORKERS: ${{ vars.PLAYWRIGHT_WORKERS || 1 }} | ||
| PLAYWRIGHT_WORKERS: ${{ vars.PLAYWRIGHT_WORKERS || '1' }} |
There was a problem hiding this comment.
The environment variable is being set as a string '1' instead of numeric 1. While this may work, Playwright typically expects numeric values for the workers configuration. Consider removing the quotes or ensuring Playwright handles string-to-number conversion correctly.
| PLAYWRIGHT_WORKERS: ${{ vars.PLAYWRIGHT_WORKERS || '1' }} | |
| PLAYWRIGHT_WORKERS: ${{ vars.PLAYWRIGHT_WORKERS || 1 }} |
1 participant
Purpose
This PR adds the tests/e2e folder to the existing pnpm workspace so it can reuse shared tools such as linters, Prettier, and other common dependencies. This helps keep tooling consistent across the project and avoids managing duplicate configurations.
Approach
Related Issues
Related PRs
Checklist
breaking changelabel added.Security checks