Fix the ID Token Validation issues due to invalid Issuer configured in the SDK#1232
Fix the ID Token Validation issues due to invalid Issuer configured in the SDK#1232brionmario merged 1 commit intoasgardeo:mainfrom
Conversation
deecb6c to
357550f
Compare
There was a problem hiding this comment.
Pull request overview
Updates Thunder’s React integration guidance and dependencies to align with the latest Asgardeo React SDK behavior, removing the previously-required tokenValidation workaround and adding a docs-site announcement banner.
Changes:
- Removed
tokenValidationfrom React integration docs, templates, and MCP tool instructions. - Bumped
@asgardeo/reactdependency from0.9.2to0.9.3(and related locked transitive updates). - Added a persistent “docs under active development” announcement banner and styling.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/pnpm-workspace.yaml | Bumps workspace catalog version of @asgardeo/react to 0.9.3. |
| frontend/pnpm-lock.yaml | Locks updated @asgardeo/react and related dependency graph changes. |
| frontend/apps/thunder-develop/src/features/applications/data/application-templates/technology-based/react.json | Updates React integration template prompts/snippets to drop tokenValidation. |
| docs/src/css/custom.css | Adds announcement-bar styling. |
| docs/docusaurus.config.ts | Enables a non-closeable announcement bar in Docusaurus config. |
| docs/content/guides/quick-start/react.mdx | Removes tokenValidation from the React quick start guide. |
| backend/internal/mcp/tools/reactsdk/tool.go | Updates MCP React SDK instructions to remove tokenValidation. |
Files not reviewed (1)
- frontend/pnpm-lock.yaml: Language not supported
...der-develop/src/features/applications/data/application-templates/technology-based/react.json
Outdated
Show resolved
Hide resolved
...der-develop/src/features/applications/data/application-templates/technology-based/react.json
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1232 +/- ##
==========================================
- Coverage 89.63% 89.62% -0.01%
==========================================
Files 605 605
Lines 39625 39622 -3
Branches 2120 2120
==========================================
- Hits 35516 35513 -3
+ Misses 2286 2285 -1
- Partials 1823 1824 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull request was closed
3560477 to
df54fad
Compare
bcf2325 to
cec2750
Compare
cec2750 to
2a1885b
Compare
2a1885b to
ce14d55
Compare
ce14d55 to
4a5fb65
Compare
4a5fb65 to
2d38e6a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 14 changed files in this pull request and generated 2 comments.
Files not reviewed (2)
- frontend/pnpm-lock.yaml: Language not supported
- samples/apps/react-sdk-sample/package-lock.json: Language not supported
| public_client: true, | ||
| token: { | ||
| issuer: 'https://localhost:8090/oauth2/token', | ||
| issuer: 'https://localhost:8090', |
There was a problem hiding this comment.
In this test fixture, mockApplication.inbound_auth_config[0].config.token.issuer was updated to https://localhost:8090, but mockRequest still uses https://localhost:8090/oauth2/token and the test asserts the request body equals mockRequest. This leaves the create-application path exercising the old issuer value, which is inconsistent with the intended issuer change. Update mockRequest (and any related assertions/fixtures) to use the new issuer as well, and align other affected application API tests that still hardcode /oauth2/token as the issuer.
| issuer: 'https://localhost:8090', | |
| issuer: 'https://localhost:8090/oauth2/token', |
| var(--site-announcement-bar-stripe-color1) 20px, | ||
| var(--site-announcement-bar-stripe-color2) 10px, | ||
| var(--site-announcement-bar-stripe-color2) 40px |
There was a problem hiding this comment.
The repeating-linear-gradient stop positions are out of order (...color1) 20px followed by ...color2) 10px). Browsers clamp decreasing stops, which makes the intended stripe widths unclear. Adjust the stop positions so they are monotonic (e.g., start color2 at the same or greater position than the preceding color1 stop).
Purpose
This pull request updates Thunder's React integration guides, templates, and code samples to simplify the configuration of the Asgardeo React SDK. The main change is the removal of the now-unnecessary
tokenValidationprop from all documentation, templates, and example code, reflecting recent improvements in the SDK and Thunder backend. Additionally, this PR updates the Asgardeo SDK to version 0.9.3 and introduces a new announcement banner to the documentation.React SDK Integration Simplification:
Removed the
tokenValidationprop from all React integration guides, code samples, and configuration instructions, both for inbuilt and custom authentication modes. Now, only the required props (clientId/applicationId,baseUrl,platform, and optionallysignInUrl) are needed forAsgardeoProviderconfiguration. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]Updated all relevant documentation and quick start guides to remove references to
tokenValidationand clarify the minimal required configuration for Thunder authentication. [1] [2] [3] [4] [5]SDK and Dependency Updates:
@asgardeo/reactSDK from version 0.9.2 to 0.9.3 in thepnpm-lock.yamlto ensure compatibility and leverage the latest improvements. [1] [2] [3] [4]Documentation Improvements:
These changes make the integration process clearer and less error-prone for developers, while also keeping dependencies up to date and improving the documentation experience.
Approach
Update the SDK with the correct Issuer: asgardeo/javascript#342
Related Issues
issuerHandling #1125Related PRs
Checklist
breaking changelabel added.Security checks