Flow service context propagation and transection usage by JeethJJ · Pull Request #1297 · asgardeo/thunder

JeethJJ · 2026-02-05T04:45:22Z

Purpose

As we have introduced the transection architecture, we are adapting our services to use transections. In this PR we have updated the flow service to use transactions.

Sub Issue : #1296
Parent issue : #282

Copilot

Pull request overview

This pull request adds context propagation and transaction support to the flow service as part of implementing the transaction architecture described in issue #282. The changes ensure that database operations can participate in transactions and that context is properly propagated through all layers.

Changes:

Added context.Context parameter to all flow service interface methods and implementations
Updated store layer to use QueryContext and ExecuteContext instead of Query and Execute for proper context propagation
Modified handler layer to extract context from HTTP requests and pass it through the call chain
Updated all tests and mocks to include context parameter with mock.Anything matchers
Integrated context propagation in dependent services (flowexec, application, export, mcp tools)

Reviewed changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
backend/internal/flow/mgt/service.go	Added context parameter to all service methods
backend/internal/flow/mgt/store.go	Added context parameter to store interface and implementations, updated to use context-aware DB methods
backend/internal/flow/mgt/handler.go	Extracts context from HTTP request and propagates to service layer
backend/internal/flow/mgt/graph_builder.go	Added context parameter to graph building methods
backend/internal/flow/mgt/*_test.go	Updated all tests with context.Background() and mock.Anything for context parameters
backend/internal/flow/mgt/*_mock_test.go	Regenerated mocks with context parameter support
backend/internal/flow/mgt/file_based_store.go	Added context parameter to file-based store operations
backend/internal/flow/mgt/cache_backed_store.go	Added context parameter to cache-backed store wrapper
backend/internal/flow/mgt/declarative_resource.go	Added context to declarative resource exporter
backend/internal/flow/flowexec/service.go	Updated flow execution service to propagate context
backend/internal/application/service.go	Updated application service to pass context to flow service calls
backend/internal/system/export/service_test.go	Updated export service tests with context parameter
backend/internal/mcp/tools/flow/tool.go	Updated MCP flow tools to propagate context

Copilot · 2026-02-05T04:48:19Z

backend/internal/application/service.go

 	defaultAuthFlowHandle := config.GetThunderRuntime().Config.Flow.DefaultAuthFlowHandle
 	defaultAuthFlow, svcErr := as.flowMgtService.GetFlowByHandle(
-		defaultAuthFlowHandle, flowcommon.FlowTypeAuthentication)
+		context.TODO(), defaultAuthFlowHandle, flowcommon.FlowTypeAuthentication)


Using context.TODO() is not recommended. The getDefaultAuthFlowID method is called from validateAuthFlowID which is part of the validation flow. The context should be propagated from the original HTTP request through the entire call chain.

Suggested change

context.TODO(), defaultAuthFlowHandle, flowcommon.FlowTypeAuthentication)

context.Background(), defaultAuthFlowHandle, flowcommon.FlowTypeAuthentication)

Its intentional as context propagation is being addressed service by service. In this PR we are focusing on the flow service.

Copilot · 2026-02-05T04:48:20Z

backend/internal/flow/mgt/declarative_resource.go

@@ -74,7 +75,7 @@ func (e *FlowGraphExporter) GetAllResourceIDs() ([]string, *serviceerror.Service

 // GetResourceByID retrieves a flow graph by its ID.
 func (e *FlowGraphExporter) GetResourceByID(id string) (interface{}, string, *serviceerror.ServiceError) {
-	flow, err := e.service.GetFlow(id)
+	flow, err := e.service.GetFlow(context.Background(), id)


Using context.Background() for GetAllResourceIDs and GetResourceByID methods in the declarative resource exporter. Since these methods are typically called during export operations that originate from HTTP requests or system operations, consider propagating the context from the caller rather than creating a new background context.

Copilot · 2026-02-05T04:48:20Z

backend/internal/flow/flowexec/service.go

 	// Initialize the engine context
 	// This uses verbose true to ensure step layouts are returned during execution
-	ctx, err := s.initContext(initContext.ApplicationID, flowType, true, logger)
+	flowCtx, err := s.initContext(context.Background(), initContext.ApplicationID, flowType, true, logger)


Using context.Background() in the InitiateFlow method. While this might be acceptable if InitiateFlow is designed to start a long-running operation, if this is called from an HTTP handler or has a parent context, that context should be passed as a parameter instead of creating a new background context.

Copilot · 2026-02-05T04:48:20Z

backend/internal/flow/mgt/file_based_store.go

 		return errors.New("invalid flow data type")
 	}
-	_, err := f.CreateFlow(flow.ID, &FlowDefinition{
+	_, err := f.CreateFlow(context.Background(), flow.ID, &FlowDefinition{


Using context.Background() in the Create method of file-based store. While file-based stores might be used in contexts where there's no request context available, if this is called from areas that do have context (like during declarative config loading), the context should be passed through.

Copilot · 2026-02-05T04:48:20Z

backend/internal/flow/mgt/store.go

 )

+// flowStoreInterface defines the interface for flow store operations.
 // flowStoreInterface defines the interface for flow store operations.


Duplicate comment: "flowStoreInterface defines the interface for flow store operations." appears twice on consecutive lines. Remove one of the duplicate lines.

Suggested change

// flowStoreInterface defines the interface for flow store operations.

Copilot · 2026-02-05T04:48:20Z

backend/internal/application/service.go

 func (as *applicationService) validateAuthFlowID(app *model.ApplicationDTO) *serviceerror.ServiceError {
 	if app.AuthFlowID != "" {
-		isValidFlow := as.flowMgtService.IsValidFlow(app.AuthFlowID)
+		isValidFlow := as.flowMgtService.IsValidFlow(context.TODO(), app.AuthFlowID)


Using context.TODO() is not recommended for production code. Since this function (validateAuthFlowID) is called from within request handlers that have access to request context, the context should be passed as a parameter through the call chain instead of using context.TODO(). This ensures proper request tracing, cancellation, and timeout propagation.

Copilot · 2026-02-05T04:48:21Z

backend/internal/application/service.go

@@ -674,7 +675,7 @@ func (as *applicationService) validateRegistrationFlowID(app *model.ApplicationD
 		}

 		registrationFlow, svcErr := as.flowMgtService.GetFlowByHandle(
-			authFlow.Handle, flowcommon.FlowTypeRegistration)
+			context.TODO(), authFlow.Handle, flowcommon.FlowTypeRegistration)


Using context.TODO() is not recommended. Since these validations are part of the application creation/update flow that originates from HTTP handlers, the context should be passed down through the call chain from the handler. Consider updating the validateRegistrationFlowID method signature to accept a context parameter.

codecov · 2026-02-05T05:00:09Z

Codecov Report

❌ Patch coverage is 83.12102% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.97%. Comparing base (ccf48d2) to head (18c64ee).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
backend/internal/flow/mgt/store.go	66.36%	18 Missing and 19 partials ⚠️
backend/internal/flow/mgt/service.go	88.59%	10 Missing and 3 partials ⚠️
backend/internal/flow/mgt/init.go	50.00%	1 Missing and 1 partial ⚠️
backend/internal/flow/flowexec/service.go	96.29%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1297      +/-   ##
==========================================
+ Coverage   89.96%   89.97%   +0.01%     
==========================================
  Files         629      629              
  Lines       41189    41198       +9     
  Branches     2390     2390              
==========================================
+ Hits        37056    37069      +13     
- Misses       2234     2240       +6     
+ Partials     1899     1889      -10

Flag	Coverage Δ
backend-integration-postgres	`?`
backend-integration-sqlite	`53.16% <64.33%> (+0.05%)`	⬆️
backend-unit	`82.58% <69.74%> (+0.12%)`	⬆️
frontend-apps-develop-unit	`90.75% <ø> (ø)`
frontend-apps-gate-unit	`84.62% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coderabbitai · 2026-02-05T09:35:48Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

Copilot reviewed 24 out of 24 changed files in this pull request and generated 2 comments.

Copilot · 2026-02-05T09:38:43Z

backend/internal/flow/mgt/graph_builder.go

 }

-// buildGraph converts a CompleteFlowDefinition to a core.GraphInterface for execution.
+// buildGraph s a CompleteFlowDefinition to a core.GraphInterface for execution.


The comment text appears to be incomplete. It reads "buildGraph s a CompleteFlowDefinition" but seems to be missing a verb. It should likely read "buildGraph converts a CompleteFlowDefinition to a core.GraphInterface for execution."

Suggested change

// buildGraph s a CompleteFlowDefinition to a core.GraphInterface for execution.

// buildGraph converts a CompleteFlowDefinition to a core.GraphInterface for execution.

Is this intentional?

Copilot · 2026-02-05T09:38:44Z

backend/internal/application/service.go

 	defaultAuthFlowHandle := config.GetThunderRuntime().Config.Flow.DefaultAuthFlowHandle
 	defaultAuthFlow, svcErr := as.flowMgtService.GetFlowByHandle(
-		defaultAuthFlowHandle, flowcommon.FlowTypeAuthentication)
+		context.TODO(), defaultAuthFlowHandle, flowcommon.FlowTypeAuthentication)


The usage of context.TODO() is not recommended here. Since this is being called from application service methods which don't currently have a context parameter, consider using context.Background() instead, or better yet, propagate context through the application service methods. context.TODO() is typically used as a placeholder during development when context propagation is not yet implemented, but this PR is specifically about adding context propagation.

Suggested change

context.TODO(), defaultAuthFlowHandle, flowcommon.FlowTypeAuthentication)

context.Background(), defaultAuthFlowHandle, flowcommon.FlowTypeAuthentication)

rajithacharith

Can you test this improvement with declarative_resources mode on and try updating or creating a flow?

rajithacharith · 2026-02-05T10:01:55Z

backend/internal/flow/mgt/declarative_resource.go

@@ -61,7 +62,7 @@ func (e *FlowGraphExporter) GetParameterizerType() string {

 // GetAllResourceIDs retrieves all flow graph IDs.
 func (e *FlowGraphExporter) GetAllResourceIDs() ([]string, *serviceerror.ServiceError) {


These functions are used when exporting the resources with /export endpoint.
That context can be used. Keep it tracked. That will be another refactoring at the last.

rajithacharith · 2026-02-05T10:03:35Z

backend/internal/flow/mgt/graph_builder.go

 }

-// buildGraph converts a CompleteFlowDefinition to a core.GraphInterface for execution.
+// buildGraph s a CompleteFlowDefinition to a core.GraphInterface for execution.


Is this intentional?

rajithacharith · 2026-02-05T10:06:45Z

backend/internal/flow/mgt/store.go

 )

+// flowStoreInterface defines the interface for flow store operations.
 // flowStoreInterface defines the interface for flow store operations.


rajithacharith · 2026-02-05T10:09:16Z

backend/internal/flow/mgt/service.go

Don't we have any scenarios we need transactions in flow mgt service?

Copilot

Pull request overview

Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.

Copilot · 2026-02-09T07:08:05Z

backend/internal/flow/mgt/service.go

+		s.logger.Debug("Flow created successfully", log.String(logKeyFlowID, flowID))
+
+		s.tryInferRegistrationFlow(ctx, flowID, flowDef)
+		return nil


tryInferRegistrationFlow is invoked inside the surrounding transactioner.Transact closure, but that helper intentionally swallows store errors. Because the inferred flow creation reuses the same transaction context (nested transactions are detected via context), a failure partway through store.CreateFlow can leave partial writes (e.g., FLOW row inserted but FLOW_VERSION insert fails) and still commit when the outer closure returns nil. Consider moving the inference call outside the transaction (after commit), or make inference run in its own independent transaction context, or propagate inference failures so the outer transaction rolls back.

…flow-service

Copilot AI review requested due to automatic review settings February 5, 2026 04:45

Copilot started reviewing on behalf of JeethJJ February 5, 2026 04:45 View session

JeethJJ force-pushed the db-transaction-mgt-flow-service branch from ccb2b1c to c353fa1 Compare February 5, 2026 04:45

JeethJJ added the Type/Improvement label Feb 5, 2026

Copilot AI reviewed Feb 5, 2026

View reviewed changes

JeethJJ force-pushed the db-transaction-mgt-flow-service branch from c353fa1 to 4894327 Compare February 5, 2026 05:21

Copilot AI review requested due to automatic review settings February 5, 2026 09:35

JeethJJ force-pushed the db-transaction-mgt-flow-service branch from 4894327 to d1ddbdb Compare February 5, 2026 09:35

Copilot started reviewing on behalf of JeethJJ February 5, 2026 09:36 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

rajithacharith reviewed Feb 5, 2026

View reviewed changes

JeethJJ force-pushed the db-transaction-mgt-flow-service branch 2 times, most recently from f70227c to 0a3681f Compare February 9, 2026 06:33

Flow service context propagation and transection usage

33df78c

Copilot AI review requested due to automatic review settings February 9, 2026 07:03

JeethJJ force-pushed the db-transaction-mgt-flow-service branch from 0a3681f to 33df78c Compare February 9, 2026 07:03

Copilot started reviewing on behalf of JeethJJ February 9, 2026 07:03 View session

Copilot AI reviewed Feb 9, 2026

View reviewed changes

Merge remote-tracking branch 'upstream/main' into db-transaction-mgt-…

18c64ee

…flow-service

	context.TODO(), defaultAuthFlowHandle, flowcommon.FlowTypeAuthentication)
	context.Background(), defaultAuthFlowHandle, flowcommon.FlowTypeAuthentication)

	// buildGraph s a CompleteFlowDefinition to a core.GraphInterface for execution.
	// buildGraph converts a CompleteFlowDefinition to a core.GraphInterface for execution.

		@@ -61,7 +62,7 @@ func (e *FlowGraphExporter) GetParameterizerType() string {

		// GetAllResourceIDs retrieves all flow graph IDs.
		func (e FlowGraphExporter) GetAllResourceIDs() ([]string, serviceerror.ServiceError) {

Conversation

JeethJJ commented Feb 5, 2026

Purpose

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

JeethJJ Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

rajithacharith Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

rajithacharith Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

rajithacharith left a comment

Choose a reason for hiding this comment

Uh oh!

rajithacharith Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

rajithacharith Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

rajithacharith Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

rajithacharith Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

codecov bot commented Feb 5, 2026 •

edited

Loading

coderabbitai bot commented Feb 5, 2026 •

edited

Loading